Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-118379: Use PyTuple_Pack #118381

Merged
merged 4 commits into from Apr 30, 2024
Merged

gh-118379: Use PyTuple_Pack #118381

merged 4 commits into from Apr 30, 2024

Conversation

nineteendo
Copy link
Contributor

@nineteendo nineteendo commented Apr 29, 2024 •
edited by bedevere-app bot

@bedevere-app bedevere-app bot mentioned this pull request Apr 29, 2024
Closed
@nineteendo
Copy link
Contributor Author

Could someone add skip news, thank you?

serhiy-storchaka
serhiy-storchaka approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

sobolevn
sobolevn approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is going to be faster. Thank you!

@erlend-aasland erlend-aasland marked this pull request as ready for review April 29, 2024 13:57
@mdboom
Copy link
Contributor

mdboom commented Apr 29, 2024

I ran this on our benchmarking infrastructure, and it seems to speed up the telco benchmark (which is the only decimal benchmark in the suite) by about 2%: https://github.com/faster-cpython/benchmarking-public/blob/main/results/bm-20240429-3.13.0a6%2B-59ac30f/bm-20240429-linux-x86_64-nineteendo-use_PyTuple_Pack-3.13.0a6%2B-59ac30f-vs-base.png

@serhiy-storchaka
Copy link
Member

If it affects the telco benchmark, and this is not a random fluctuation, there should be possible to create a microbenchmark that shows the tens percents difference.

@serhiy-storchaka serhiy-storchaka merged commit 9a75d56 into python:main Apr 30, 2024
34 checks passed
@nineteendo nineteendo deleted the use-PyTuple_Pack branch April 30, 2024 15:01
SonicField pushed a commit to SonicField/cpython that referenced this pull request May 8, 2024
@nineteendo @SonicField
pythongh-118379: Use PyTuple_Pack instead of Py_BuildValue if possible (
28ab858 
pythonGH-118381)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhettinger rhettinger rhettinger left review comments

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@sobolevn sobolevn sobolevn approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nineteendo @mdboom @serhiy-storchaka @rhettinger @sobolevn