Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-118347: Fix Windows installer not updating launcher #118386

Merged
merged 1 commit into from Apr 29, 2024
Merged

gh-118347: Fix Windows installer not updating launcher #118386

merged 1 commit into from Apr 29, 2024

Conversation

zooba
Copy link
Member

@zooba zooba commented Apr 29, 2024 •
edited by bedevere-app bot

@zooba zooba added OS-windows needs backport to 3.12 bug and security fixes labels Apr 29, 2024
@zooba zooba requested a review from a team as a code owner April 29, 2024 12:55
@bedevere-app bedevere-app bot mentioned this pull request Apr 29, 2024
Closed
@zooba zooba merged commit 96d8ca7 into python:main Apr 29, 2024
42 checks passed
@miss-islington-app
Copy link

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@zooba
Copy link
Member Author

zooba commented Apr 29, 2024

Confirmed with manual testing (and actually checking the final install this time, not just the installer behaviour ;) )

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 29, 2024
@zooba @miss-islington
pythongh-118347: Fix Windows installer not updating launcher (pythonG…
477f1fb 
…H-118386)

(cherry picked from commit 96d8ca7)

Co-authored-by: Steve Dower <steve.dower@python.org>
@zooba zooba deleted the gh-118347 branch April 29, 2024 20:46
@bedevere-app
Copy link

bedevere-app bot commented Apr 29, 2024

GH-118409 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Apr 29, 2024
zooba added a commit that referenced this pull request Apr 29, 2024
@miss-islington @zooba
gh-118347: Fix Windows installer not updating launcher (GH-118386)
97c0194 
(cherry picked from commit 96d8ca7)

Co-authored-by: Steve Dower <steve.dower@python.org>
SonicField pushed a commit to SonicField/cpython that referenced this pull request May 8, 2024
@zooba @SonicField
pythongh-118347: Fix Windows installer not updating launcher (pythonG…
e150c8a 
…H-118386)
SonicField pushed a commit to SonicField/cpython that referenced this pull request May 8, 2024
@zooba @SonicField
pythongh-118347: Fix Windows installer not updating launcher (pythonG…
8b320da 
…H-118386)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
OS-windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@zooba