Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-61698: Use launchctl to detect macOS window manager in tests #118390

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

gh-61698: Use launchctl to detect macOS window manager in tests #118390

wants to merge 1 commit into from

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Apr 29, 2024 •
edited by bedevere-app bot

@bedevere-app bedevere-app bot mentioned this pull request Apr 29, 2024
Open
@erlend-aasland erlend-aasland added skip news needs backport to 3.12 bug and security fixes tests Tests in the Lib/test dir labels Apr 29, 2024
@erlend-aasland erlend-aasland marked this pull request as ready for review April 29, 2024 14:13
ronaldoussoren
ronaldoussoren approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@ronaldoussoren ronaldoussoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I'd definitely check if it works on our buildbots before committing this though, with some luck those have a setup that claims to be an Aqua session but isn't.

@erlend-aasland erlend-aasland added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 29, 2024
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit 37eec0b 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 29, 2024
@erlend-aasland
Copy link
Contributor Author

Unfortunately, the sessions on the macOS CIs claim to be Aqua, so this won't work.

@erlend-aasland
Copy link
Contributor Author

The ARM64 MacOS M1 Refleaks NoGIL PR buildbot correctly skips the tests, though.

@erlend-aasland
Copy link
Contributor Author

OTOH, we could fix (or skip) the failing tkinter tests and go on with this PR.

@serhiy-storchaka serhiy-storchaka added the needs backport to 3.13 bugs and security fixes label May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronaldoussoren ronaldoussoren ronaldoussoren approved these changes

Assignees
No one assigned
Labels
awaiting merge needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@erlend-aasland @bedevere-bot @ronaldoussoren @serhiy-storchaka