-
-
Notifications
You must be signed in to change notification settings - Fork 29.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-106246: Allow the use of unions as match patterns #118644
Open
randolf-scholz
wants to merge
21
commits into
python:main
Choose a base branch
from
randolf-scholz:fix-issue-118524-match-union
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
gh-106246: Allow the use of unions as match patterns #118644
randolf-scholz
wants to merge
21
commits into
python:main
from
randolf-scholz:fix-issue-118524-match-union
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randolf-scholz
requested review from
brandtbucher,
markshannon and
gvanrossum
as code owners
May 6, 2024 12:31
randolf-scholz
commented
May 6, 2024
Thanks for working on this! |
sobolevn
reviewed
May 7, 2024
randolf-scholz
force-pushed
the
fix-issue-118524-match-union
branch
from
May 7, 2024 13:49
b38a4cb
to
767f5dc
Compare
Too late for 3.13 :( |
While you have some time, I recommend adding some great docs for the new feature as well. |
Eclips4
reviewed
May 19, 2024
Misc/NEWS.d/next/Core and Builtins/2024-05-02-20-16-12.gh-issue-118524.B4rIYi.rst
Outdated
Show resolved
Hide resolved
…e-118524.B4rIYi.rst Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #106246
Modified version of #118525 that supports using subpatterns in unions.
added tests: