Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-118820: Zero-valued flag enum has no name #118848

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

nineteendo
Copy link
Contributor

@nineteendo nineteendo commented May 9, 2024

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news labels May 9, 2024
@nineteendo nineteendo marked this pull request as ready for review May 9, 2024 15:30
Doc/howto/enum.rst Outdated Show resolved Hide resolved
@bedevere-app
Copy link

bedevere-app bot commented May 9, 2024

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

nineteendo and others added 2 commits May 9, 2024 19:09
Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
@nineteendo
Copy link
Contributor Author

ethanfurman, I have made the requested changes; please review again.

@bedevere-app
Copy link

bedevere-app bot commented May 9, 2024

Thanks for making the requested changes!

@ethanfurman: please review the changes made to this pull request.

@bedevere-app bedevere-app bot requested a review from ethanfurman May 9, 2024 17:10
@TeamSpen210
Copy link

It might be more clear to do Perm(0), since it took me a moment to realise the intersection would exclude everything.

@nineteendo
Copy link
Contributor Author

Note that ...(0) is only used once on the page, ... & ... is used 4 more times. But if Ethan agrees, I'll change it.

Doc/howto/enum.rst Outdated Show resolved Hide resolved
@bedevere-app
Copy link

bedevere-app bot commented May 9, 2024

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
@nineteendo
Copy link
Contributor Author

I have made the requested changes; please review again.

@bedevere-app
Copy link

bedevere-app bot commented May 9, 2024

Thanks for making the requested changes!

@ethanfurman: please review the changes made to this pull request.

@bedevere-app bedevere-app bot requested a review from ethanfurman May 9, 2024 21:00
Doc/howto/enum.rst Outdated Show resolved Hide resolved
nineteendo and others added 3 commits June 9, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting merge docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants