Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-118899: Add tests for NotImplemented attribute access #118902

Merged
merged 3 commits into from
May 12, 2024
Merged

gh-118899: Add tests for NotImplemented attribute access #118902

merged 3 commits into from
May 12, 2024

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented May 10, 2024 •
edited by bedevere-app bot

@bedevere-app bedevere-app bot added tests Tests in the Lib/test dir awaiting core review labels May 10, 2024
@bedevere-app bedevere-app bot mentioned this pull request May 10, 2024
Closed
@sobolevn sobolevn enabled auto-merge (squash) May 12, 2024 13:46
@sobolevn sobolevn added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels May 12, 2024
@sobolevn
Copy link
Member Author

Test changes are usually backported.

@sobolevn sobolevn merged commit ec1398e into python:main May 12, 2024
35 checks passed
@miss-islington-app
Copy link

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 12, 2024
@sobolevn @miss-islington
pythongh-118899: Add tests for NotImplemented attribute access (pyt…
bccb0fa 
…honGH-118902)

(cherry picked from commit ec1398e)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-app
Copy link

bedevere-app bot commented May 12, 2024

GH-118968 is a backport of this pull request to the 3.13 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 12, 2024
@sobolevn @miss-islington
pythongh-118899: Add tests for NotImplemented attribute access (pyt…
351358b 
…honGH-118902)

(cherry picked from commit ec1398e)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 12, 2024
@bedevere-app
Copy link

bedevere-app bot commented May 12, 2024

GH-118969 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label May 12, 2024
sobolevn added a commit that referenced this pull request May 12, 2024
@miss-islington @sobolevn
[3.12] gh-118899: Add tests for NotImplemented attribute access (GH…
76dc1bf 
…-118902) (#118969)

gh-118899: Add tests for `NotImplemented` attribute access (GH-118902)
(cherry picked from commit ec1398e)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
sobolevn added a commit that referenced this pull request May 12, 2024
@miss-islington @sobolevn
[3.13] gh-118899: Add tests for NotImplemented attribute access (GH…
6e855b3 
…-118902) (#118968)

gh-118899: Add tests for `NotImplemented` attribute access (GH-118902)
(cherry picked from commit ec1398e)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sobolevn @JelleZijlstra