Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-119064: Use os_helper.FakePath instead of pathlib.Path in tests #119065

Merged
merged 2 commits into from
May 16, 2024
Merged

gh-119064: Use os_helper.FakePath instead of pathlib.Path in tests #119065

merged 2 commits into from
May 16, 2024

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented May 15, 2024 •
edited by bedevere-app bot

@serhiy-storchaka serhiy-storchaka added skip news needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels May 15, 2024
@bedevere-app bedevere-app bot added tests Tests in the Lib/test dir awaiting core review labels May 15, 2024
@bedevere-app bedevere-app bot mentioned this pull request May 15, 2024
Closed
hauntsaninja
hauntsaninja approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one comment

Lib/test/test_tarfile.py Outdated Show resolved Hide resolved
serhiy-storchaka
serhiy-storchaka commented May 16, 2024
View reviewed changes
Lib/test/test_tarfile.py Outdated Show resolved Hide resolved
Lib/test/test_tarfile.py Outdated Show resolved Hide resolved
@serhiy-storchaka serhiy-storchaka merged commit 0152dc4 into python:main May 16, 2024
31 checks passed
@miss-islington-app
Copy link

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the test-path-like branch May 16, 2024 07:25
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 16, 2024
@serhiy-storchaka @miss-islington
pythongh-119064: Use os_helper.FakePath instead of pathlib.Path in te…
c4c1b04 
…sts (pythonGH-119065)

(cherry picked from commit 0152dc4)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@miss-islington-app
Copy link

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 0152dc4ff5534fa2948b95262e70ff6b202b9b99 3.12

@bedevere-app
Copy link

bedevere-app bot commented May 16, 2024

GH-119087 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 16, 2024
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request May 16, 2024
@serhiy-storchaka
[3.12] pythongh-119064: Use os_helper.FakePath instead of pathlib.Pat…
b4b2738 
…h in tests (pythonGH-119065)

(cherry picked from commit 0152dc4)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented May 16, 2024

GH-119088 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label May 16, 2024
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request May 16, 2024
@serhiy-storchaka
[3.11] pythongh-119064: Use os_helper.FakePath instead of pathlib.Pat…
b1d7360 
…h in tests (pythonGH-119065)

(cherry picked from commit 0152dc4)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented May 16, 2024

GH-119089 is a backport of this pull request to the 3.11 branch.

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request May 16, 2024
@serhiy-storchaka
[3.12] pythongh-119064: Use os_helper.FakePath instead of pathlib.Pat…
fb1870a 
…h in tests (pythonGH-119065)

(cherry picked from commit 0152dc4)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull request May 16, 2024
@miss-islington @serhiy-storchaka
[3.13] gh-119064: Use os_helper.FakePath instead of pathlib.Path in t…
1dc7fcd 
…ests (GH-119065) (GH-119087)

(cherry picked from commit 0152dc4)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@jaraco
Copy link
Member

jaraco commented May 16, 2024

These changes will need to be backported to zipp as well.

@jaraco jaraco mentioned this pull request May 16, 2024
Closed
@jaraco
Copy link
Member

jaraco commented May 16, 2024

Also configparser.

@jaraco jaraco mentioned this pull request May 16, 2024
Open
@jaraco
Copy link
Member

jaraco commented May 16, 2024

And backports.tarfile.

@jaraco jaraco mentioned this pull request May 16, 2024
Closed
serhiy-storchaka added a commit that referenced this pull request May 16, 2024
@serhiy-storchaka
[3.12] gh-119064: Use os_helper.FakePath instead of pathlib.Path in t…
33a9f0c 
…ests (GH-119065) (GH-119088)

(cherry picked from commit 0152dc4)
jaraco pushed a commit to jaraco/zipp that referenced this pull request May 16, 2024
@serhiy-storchaka @jaraco
gh-119064: Use os_helper.FakePath instead of pathlib.Path in tests (p…
cdbd58b 
…ython/cpython#119065)

Closes #116.
@jaraco jaraco mentioned this pull request May 16, 2024
Closed
clrpackages pushed a commit to clearlinux-pkgs/pypi-zipp that referenced this pull request May 17, 2024
@fenrus75
pypi-zipp: Autospec creation for update from version 3.18.1 to versio…
c1306f5 
…n 3.18.2

Avasam (1):
      Allow mypy on PyPy (jaraco/skeleton#111)

Bartosz Sławecki (2):
      Add link to blog entry from jaraco/skeleton#115 above CI build matrix.
      Move project metadata to `pyproject.toml` (jaraco/skeleton#122)

Jason R. Coombs (13):
      Update compatibility matrix to reflect changes merged in Python 3.12 and anticipated for 3.13.
      Re-enable ignoring of temporary merge queue branches. Closes jaraco/skeleton#103.
      Fetch unshallow clones in readthedocs. Closes jaraco/skeleton#114.
      Move Python 3.11 out of the test matrix.
      Configure pytest to support namespace packages. Ref pytest-dev/pytest#12112.
      Pin against pytest 8.1.x due to pytest-dev/pytest#12194.
      Migrated config to pyproject.toml using jaraco.develop.migrate-config and ini2toml.
      Allow macos on Python 3.8 to fail as GitHub CI has dropped support.
      Move project.urls to appear in the order that ini2toml generates it. Remove project.scripts.
      Revert "Allow macos on Python 3.8 to fail as GitHub CI has dropped support."
      Utilize temp_dir from os_helper.
      Use an overlay object to make tests appear to use zipfile.Path to reduce diff with CPython.
      Finalize

Serhiy Storchaka (1):
      gh-119064: Use os_helper.FakePath instead of pathlib.Path in tests (python/cpython#119065)

Xie Yanbo (1):
      Fix typo in Lib/zipfile/_path/__init__.py
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes

@jaraco jaraco Awaiting requested review from jaraco jaraco is a code owner

@ethanfurman ethanfurman Awaiting requested review from ethanfurman ethanfurman is a code owner

@gpshead gpshead Awaiting requested review from gpshead gpshead is a code owner

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@vsajip vsajip Awaiting requested review from vsajip vsajip is a code owner

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@gvanrossum gvanrossum Awaiting requested review from gvanrossum gvanrossum is a code owner

@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner

@willingc willingc Awaiting requested review from willingc willingc is a code owner

Assignees

@serhiy-storchaka serhiy-storchaka

Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@serhiy-storchaka @jaraco @hauntsaninja