Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable some stricter mypy settings on Lib/_pyrepl #119077

Merged
merged 3 commits into from
May 20, 2024
Merged

Enable some stricter mypy settings on Lib/_pyrepl #119077

merged 3 commits into from
May 20, 2024

Conversation

AlexWaygood
Copy link
Member

Some low-hanging fruit I noticed

@AlexWaygood AlexWaygood added the topic-repl Related to the interactive shell label May 15, 2024
@AlexWaygood AlexWaygood requested a review from ambv May 15, 2024 18:47
@AlexWaygood AlexWaygood merged commit 0883fd2 into python:main May 20, 2024
39 checks passed
@AlexWaygood AlexWaygood deleted the pyrepl-mypy branch May 20, 2024 12:52
@lysnikolaou lysnikolaou added the needs backport to 3.13 bugs and security fixes label May 22, 2024
@miss-islington-app
Copy link

Thanks @AlexWaygood for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 22, 2024
@AlexWaygood @miss-islington
Enable some stricter mypy settings on Lib/_pyrepl (pythonGH-119077)
5b8cb09 
(cherry picked from commit 0883fd2)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented May 22, 2024

GH-119428 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 22, 2024
ambv pushed a commit that referenced this pull request May 22, 2024
@miss-islington @AlexWaygood
[3.13] Enable some stricter mypy settings on Lib/_pyrepl (GH-119077) (
81440c5 
#119428)

(cherry picked from commit 0883fd2)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambv ambv Awaiting requested review from ambv ambv is a code owner

Assignees
No one assigned
Labels
skip issue skip news topic-repl Related to the interactive shell
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AlexWaygood @lysnikolaou