Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-119132: Log sys._is_gil_disabled() in test.pythoninfo #119140

Merged
merged 2 commits into from
May 18, 2024
Merged

gh-119132: Log sys._is_gil_disabled() in test.pythoninfo #119140

merged 2 commits into from
May 18, 2024

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented May 18, 2024 •
edited by bedevere-app bot
Loading

@vstinner vstinner added skip news needs backport to 3.13 bugs and security fixes labels May 18, 2024
@bedevere-app bedevere-app bot mentioned this pull request May 18, 2024
Closed
@vstinner
Copy link
Member Author

cc @corona10

corona10
corona10 approved these changes May 18, 2024
View reviewed changes
Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@vstinner
Copy link
Member Author

Example on "Tests / Windows (free-threading) / build and test (x64) (pull_request)":

sys._is_gil_enabled: False

It works as expected.

@vstinner vstinner merged commit 74072a3 into python:main May 18, 2024
31 checks passed
@vstinner vstinner deleted the pythoninfo branch May 18, 2024 13:24
@miss-islington-app
Copy link

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 18, 2024
@vstinner @miss-islington
pythongh-119132: Log sys._is_gil_enabled() in test.pythoninfo (python…
b450d53 
…GH-119140)

(cherry picked from commit 74072a3)

Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-app
Copy link

bedevere-app bot commented May 18, 2024

GH-119143 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 18, 2024
@vstinner
Copy link
Member Author

Merged, thanks for reviews.

vstinner added a commit that referenced this pull request May 18, 2024
@miss-islington @vstinner
[3.13] gh-119132: Log sys._is_gil_enabled() in test.pythoninfo (GH-11…
9c2de86 
…9140) (#119143)

gh-119132: Log sys._is_gil_enabled() in test.pythoninfo (GH-119140)
(cherry picked from commit 74072a3)

Co-authored-by: Victor Stinner <vstinner@python.org>
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corona10 corona10 corona10 approved these changes

@erlend-aasland erlend-aasland erlend-aasland approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vstinner @corona10 @erlend-aasland