bpo-35933: Document/fix case when __getstate__ returns a tuple of 2 dictionnaries #11955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pppery
reviewed
Feb 20, 2019
|
Could you change the description of your PR because bedevere can't find the right associated issue. Thank you |
pierreglaser
changed the title
pierreglaser
changed the title
pitrou
reviewed
May 10, 2019
| @@ -6233,7 +6233,7 @@ load_build(UnpicklerObject *self) | |||
| slotstate = NULL; | |||
|
|
|||
| /* Set inst.__dict__ from the state dict (if any). */ | |||
| if (state != Py_None) { | |||
| if (PyObject_IsTrue(state)) { | |||
There was a problem hiding this comment.
Any reason you're changing this?
There was a problem hiding this comment.
Consistency with pickle.py.
But this PR documents an implementation detail and makes a quasi-non significant change, so feel free to close it.
There was a problem hiding this comment.
If you say so :-) I'm closing now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bpo-35933: Document/fix case when getstate returns a tuple of 2 dictionnaries
test_descr.pyalready tests this functionality pretty thoroughly._pickle.cis simply for the sake of consistency betweenpickle.pyand_pickle.chttps://bugs.python.org/issue35933