[3.13] gh-119369: Fix deadlock during thread exit in free-threaded build (GH-119528) #119868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ld (pythonGH-119528) Release the GIL before calling `_Py_qsbr_unregister`. The deadlock could occur when the GIL was enabled at runtime. The `_Py_qsbr_unregister` call might block while holding the GIL because the thread state was not active, but the GIL was still held. (cherry picked from commit 078b8c8) Co-authored-by: Sam Gross <colesbury@gmail.com>
This was referenced May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release the GIL before calling
_Py_qsbr_unregister.The deadlock could occur when the GIL was enabled at runtime. The
_Py_qsbr_unregistercall might block while holding the GIL because thethread state was not active, but the GIL was still held.
(cherry picked from commit 078b8c8)
Co-authored-by: Sam Gross colesbury@gmail.com
pool_in_threads.py(test_multiprocessing_pool_circular_import) in free-threaded build #119369