Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-119003: Clarify slice assignments #119935

Merged
merged 2 commits into from
Jun 21, 2024
Merged

gh-119003: Clarify slice assignments #119935

merged 2 commits into from
Jun 21, 2024

Conversation

nineteendo
Copy link
Contributor

@nineteendo nineteendo commented Jun 2, 2024 •
edited by github-actions bot
Loading

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news labels Jun 2, 2024
@bedevere-app bedevere-app bot mentioned this pull request Jun 2, 2024
Closed
@nineteendo nineteendo marked this pull request as ready for review June 2, 2024 05:44
@hauntsaninja hauntsaninja added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Jun 2, 2024
hauntsaninja
hauntsaninja approved these changes Jun 2, 2024
View reviewed changes
Copy link
Contributor

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@nineteendo @erlend-aasland
Update Doc/library/stdtypes.rst
c4aee1e 
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@nineteendo
Copy link
Contributor Author

Can this be merged?

@hauntsaninja hauntsaninja merged commit 4628320 into python:main Jun 21, 2024
25 checks passed
@miss-islington-app
Copy link

Thanks @nineteendo for the PR, and @hauntsaninja for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 21, 2024
@nineteendo @miss-islington
pythongh-119003: Clarify slice assignments (pythonGH-119935)
2411c6c 
(cherry picked from commit 4628320)

Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 21, 2024
@nineteendo @miss-islington
pythongh-119003: Clarify slice assignments (pythonGH-119935)
2fddf71 
(cherry picked from commit 4628320)

Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Jun 21, 2024

GH-120847 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jun 21, 2024
@bedevere-app
Copy link

bedevere-app bot commented Jun 21, 2024

GH-120848 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Jun 21, 2024
@nineteendo nineteendo deleted the clarify-slice-assignments branch June 21, 2024 18:31
kumaraditya303 pushed a commit that referenced this pull request Jun 23, 2024
@miss-islington @nineteendo
[3.12] gh-119003: Clarify slice assignments (GH-119935) (#120848)
2b25305 
gh-119003: Clarify slice assignments (GH-119935)
(cherry picked from commit 4628320)

Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>
kumaraditya303 pushed a commit that referenced this pull request Jun 23, 2024
@miss-islington @nineteendo
[3.13] gh-119003: Clarify slice assignments (GH-119935) (#120847)
bf7aac3 
gh-119003: Clarify slice assignments (GH-119935)
(cherry picked from commit 4628320)

Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>
mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
@nineteendo @mrahtz
pythongh-119003: Clarify slice assignments (python#119935)
d2b6941
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@nineteendo @noahbkim
pythongh-119003: Clarify slice assignments (python#119935)
921f0d4
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@nineteendo @estyxx
pythongh-119003: Clarify slice assignments (python#119935)
3940670
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlend-aasland erlend-aasland erlend-aasland left review comments

@hauntsaninja hauntsaninja hauntsaninja approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nineteendo @hauntsaninja @erlend-aasland