gh-120254: Add a commands argument to pdb.Pdb
#120255
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
picnixz
reviewed
Jun 9, 2024
Comment on lines
+214
to
+215
| The *commands* argument, if given, would be a list of commands to execute | ||
| when the debugger starts. It has similar effects to the :file:`.pdbrc` file. |
There was a problem hiding this comment.
Suggested change
| The *commands* argument, if given, would be a list of commands to execute | |
| when the debugger starts. It has similar effects to the :file:`.pdbrc` file. | |
| The *commands* argument, if given, is a list of commands to execute | |
| when the debugger starts. Those commands are executed after those | |
| optionally provided by the :file:`.pdbrc` file. |
There was a problem hiding this comment.
Do you think two "those" is a little bit confusing here? How about These commands are executed after any commands optionally provided by the :file:.pdbrc file?
There was a problem hiding this comment.
I agree the double "those" is confusing.
There was a problem hiding this comment.
Oups, you're right! I'm sorry I didn't reply to your question 3 weeks ago btw, but yes your suggestion is way better!
| @@ -0,0 +1 @@ | |||
| Added ``commands`` argument to :class:`pdb.Pdb` which allows user to send debugger commands in the source file. | |||
There was a problem hiding this comment.
Suggested change
| Added ``commands`` argument to :class:`pdb.Pdb` which allows user to send debugger commands in the source file. | |
| Added ``commands`` argument to :class:`pdb.Pdb` which allows users to send debugger commands in the source file. |
mcepl
reviewed
Jun 10, 2024
| @@ -211,6 +211,9 @@ access further features, you have to do this yourself: | |||
| The *readrc* argument defaults to true and controls whether Pdb will load | |||
| .pdbrc files from the filesystem. | |||
|
|
|||
| The *commands* argument, if given, would be a list of commands to execute | |||
| when the debugger starts. It has similar effects to the :file:`.pdbrc` file. | |||
There was a problem hiding this comment.
The phrase “similar effects” is kind of vague. I am not sure how to say it more precisely. Link to the .pdbrc documentation? Not sure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commandsargument topdb.Pdbso the user can feed commands from source code #120254📚 Documentation preview 📚: https://cpython-previews--120255.org.readthedocs.build/