Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-89083: add support for UUID version 6 (RFC 9562) #120650

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

picnixz
Copy link
Contributor

@picnixz picnixz commented Jun 17, 2024

In light of the discussion in #89083, I decided to remove the previous commits on version 7 and 8 and restrict this specific PR to version 6 only. The previous post can be found in the history of this message.

For version 7, please discuss it on #121119. I won't prepare something for version 8 since the implementation is still not yet decided.


📚 Documentation preview 📚: https://cpython-previews--120650.org.readthedocs.build/

@picnixz

This comment was marked as resolved.

Lib/uuid.py Outdated Show resolved Hide resolved
Lib/uuid.py Outdated Show resolved Hide resolved
Doc/whatsnew/3.14.rst Outdated Show resolved Hide resolved
Lib/uuid.py Show resolved Hide resolved
@picnixz picnixz changed the title gh-89083: support UUID versions 6, 7, and 8 (RFC 9562) gh-89083: support UUID versions 6, 7 (non-monotonous), and 8 (mt19937-based) (RFC 9562) Jun 22, 2024
@picnixz picnixz changed the title gh-89083: support UUID versions 6, 7 (non-monotonous), and 8 (mt19937-based) (RFC 9562) gh-89083: support UUID version 6 (RFC 9562) Jun 28, 2024
@picnixz picnixz changed the title gh-89083: support UUID version 6 (RFC 9562) gh-89083: add ref. impl. for UUID version 6 (RFC 9562) Jun 28, 2024
@merwok
Copy link
Member

merwok commented Jun 28, 2024

I am puzzled by the PR title change – can you explain?

@picnixz
Copy link
Contributor Author

picnixz commented Jun 28, 2024

Oh yes, after we discussed the v7 implementation, I preferred splitting the PR into 3 with one PR for each version. The ref. impl. means reference implementation but maybe I should have use the expanded wording? (I wanted to have the same title as for the v7 and not a too long title)

@merwok
Copy link
Member

merwok commented Jun 28, 2024

«Reference implementation» makes me think that this code is in support or a spec, and maybe not best-written or optimized for production. If this is not the case, just «implementation» or «support» like before has the right connotations 🙂

@picnixz
Copy link
Contributor Author

picnixz commented Jun 28, 2024

Sure, I can make the change if you want (I'll edit the other title as well)

@picnixz picnixz changed the title gh-89083: add ref. impl. for UUID version 6 (RFC 9562) gh-89083: add support for UUID version 6 (RFC 9562) Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants