gh-85453: Improve variable mark up on datetime.rst #120702
Open
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bedevere-app
bot
added
docs
uatach
commented
Jun 18, 2024
| @@ -1213,7 +1213,7 @@ Supported operations: | |||
|
|
|||
| If both are naive, or both are aware and have the same :attr:`~.datetime.tzinfo` attribute, | |||
| the :attr:`~.datetime.tzinfo` attributes are ignored, and the result is a :class:`timedelta` | |||
| object *t* such that ``datetime2 + t == datetime1``. No time zone adjustments | |||
| object ``t`` such that ``datetime2 + t == datetime1``. No time zone adjustments | |||
There was a problem hiding this comment.
@erlend-aasland I've found several occurrences like these, they don't seem to be method or function parameters like you said in #85453 (comment), but I'm not sure if they should all be marked up as variables.
There was a problem hiding this comment.
I think these fall in the variables/literals/code category of our style guide:
https://devguide.python.org/documentation/markup/#quick-reference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another pull request based on PR #21447, this one focused on improving variable mark up.
📚 Documentation preview 📚: https://cpython-previews--120702.org.readthedocs.build/