Docs makefile/RTD: Use uv if installed #120711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugovk
added
needs backport to 3.12
|
Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
|
Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
|
Sorry, @hugovk, I could not cleanly backport this to |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 23, 2024
(cherry picked from commit bc37ac7) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
|
GH-120922 is a backport of this pull request to the 3.13 branch. |
|
GH-120923 is a backport of this pull request to the 3.12 branch. |
hugovk
added a commit
to hugovk/cpython
that referenced
this pull request
Jun 23, 2024
(cherry picked from commit bc37ac7) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
hugovk
added a commit
that referenced
this pull request
Jun 23, 2024
hugovk
added a commit
that referenced
this pull request
Jun 23, 2024
mrahtz
pushed a commit
to mrahtz/cpython
that referenced
this pull request
Jun 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like python/devguide#1320 and python/peps#3791.
Using uv to install dependencies is quicker than pip.
Locally, running
make -C Doc clean-venv; time make -C Doc venvwith no cache goes from 8.9s -> 2.4s:make -C Doc venv 4.81s user 1.52s system 71% cpu 8.896 totalmake -C Doc venv 0.91s user 1.00s system 81% cpu 2.345 totalAnd with a warm cache goes from 5.03s -> 0.08s:
make -C Doc venv 3.47s user 0.82s system 85% cpu 5.033 totalmake -C Doc venv 0.02s user 0.07s system 109% cpu 0.080 totalOn Read the Docs, it adds 2 seconds to install uv, and then cuts the docs build time from 199s -> 190s, about 7s reduction in all.
RTD+uv docs: https://docs.readthedocs.io/en/stable/build-customization.html#install-dependencies-with-uv
📚 Documentation preview 📚: https://cpython-previews--120711.org.readthedocs.build/