Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amend categories of @nineteendo's news entries #120735

Merged
merged 17 commits into from
Jun 21, 2024
Merged

Amend categories of @nineteendo's news entries #120735

merged 17 commits into from
Jun 21, 2024

Conversation

nineteendo
Copy link
Contributor

No description provided.

@bedevere-app bedevere-app bot added the docs Documentation in the Doc dir label Jun 19, 2024
@nineteendo
Copy link
Contributor Author

@erlend-aasland, I always used the wrong category for my news entries. Sorry.

@nineteendo nineteendo marked this pull request as ready for review June 19, 2024 11:56
@nineteendo nineteendo mentioned this pull request Jun 19, 2024
Merged
@nineteendo nineteendo changed the title Amend categories of my previous news entries Amend categories of @nineteendo's news entries Jun 19, 2024
@nineteendo
Copy link
Contributor Author

@kumaraditya303, you mentioned the news category of my pull request was incorrect. This is also the case for my previous pull requests.

@nineteendo nineteendo requested a review from carljm June 21, 2024 05:30
@carljm
Copy link
Member

carljm commented Jun 21, 2024

Hmm, it looks to me like Misc/NEWS.d/3.13.0a6 is sorted by category, and this PR breaks that sorting. I'm not sure if it's sufficient to just move the changed items down with the other Library items -- seems like that would probably be fine, but I'm not super familiar with our tooling for generating What's New. Would you be able to look into the tooling that generates the summary What's New files at release time, and confirm that what you've done here should leave things in the same state they'd have been in if this change had been made in the original PRs? Thanks.

The recategorization of these changes to Library does look correct to me.

@nineteendo
Copy link
Contributor Author

"bedevere/news — News entry file name incorrectly formatted"

Could you add skip-news? This message means it found a moved news entry.

@carljm carljm added the needs backport to 3.13 bugs and security fixes label Jun 21, 2024
@carljm carljm merged commit 1dadcb5 into python:main Jun 21, 2024
29 checks passed
@miss-islington-app
Copy link

Thanks @nineteendo for the PR, and @carljm for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @nineteendo and @carljm, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 1dadcb5a6a821dd6ab397cf52a2fa9618839d8c0 3.13

@carljm
Copy link
Member

carljm commented Jun 21, 2024

@nineteendo Can you create a backport of this to 3.13? Thanks!

@nineteendo
Copy link
Contributor Author

Yeah, was just going to say it.

@nineteendo nineteendo deleted the amend-news-entries branch June 21, 2024 18:21
@bedevere-app
Copy link

bedevere-app bot commented Jun 21, 2024

GH-120850 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jun 21, 2024
@bedevere-app
Copy link

bedevere-app bot commented Jun 21, 2024

GH-120736 is a backport of this pull request to the 3.12 branch.

@nineteendo
Copy link
Contributor Author

Could you merge the backports?

carljm pushed a commit that referenced this pull request Jun 22, 2024
@nineteendo
[3.13] Amend categories of @nineteendo's news entries (GH-120735) (#1…
41b2d19 
…20850)
carljm pushed a commit that referenced this pull request Jun 22, 2024
@nineteendo
[3.12] Amend categories of @nineteendo's news entries (GH-120735) (#1…
b644885 
…20736)
@carljm
Copy link
Member

carljm commented Jun 22, 2024

Done

@nineteendo nineteendo mentioned this pull request Jun 23, 2024
Open
mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
@nineteendo @mrahtz
Amend categories of @nineteendo's news entries (python#120735)
597d99d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carljm carljm carljm approved these changes

Assignees

@carljm carljm

Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nineteendo @carljm