Update example of str.split, bytes.split #121287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `{str,bytes}.strip(chars)`, multiple characters are not treated as a
prefix/suffix, but as individual characters. This may make users confuse
whether `split` has similar behavior.
Users may incorrectly expect that
`'Good morning, John.'.split(', .') == ['Good', 'morning', 'John']`
Adding a bit of clarification in the doc.
bedevere-app
bot
added
docs
hauntsaninja
approved these changes
Jul 4, 2024
hauntsaninja
added
needs backport to 3.12
|
Thanks @ppwwyyxx for the PR, and @hauntsaninja for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
|
GH-121415 is a backport of this pull request to the 3.13 branch. |
|
GH-121416 is a backport of this pull request to the 3.12 branch. |
bedevere-app
bot
removed
needs backport to 3.12
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 5, 2024
In `{str,bytes}.strip(chars)`, multiple characters are not treated as a
prefix/suffix, but as individual characters. This may make users confuse
whether `split` has similar behavior.
Users may incorrectly expect that
`'Good morning, John.'.split(', .') == ['Good', 'morning', 'John']`
Adding a bit of clarification in the doc.
(cherry picked from commit 892e3a1)
Co-authored-by: Yuxin Wu <ppwwyyxxc@gmail.com>
Co-authored-by: Yuxin Wu <ppwwyyxx@users.noreply.github.com>
hauntsaninja
pushed a commit
that referenced
this pull request
Jul 5, 2024
Update example of str.split, bytes.split (GH-121287) In `{str,bytes}.strip(chars)`, multiple characters are not treated as a prefix/suffix, but as individual characters. This may make users confuse whether `split` has similar behavior. Users may incorrectly expect that `'Good morning, John.'.split(', .') == ['Good', 'morning', 'John']` Adding a bit of clarification in the doc. (cherry picked from commit 892e3a1) Co-authored-by: Yuxin Wu <ppwwyyxxc@gmail.com> Co-authored-by: Yuxin Wu <ppwwyyxx@users.noreply.github.com>
miss-islington
added a commit
to miss-islington/cpython
that referenced
this pull request
Jul 5, 2024
…thon#121415) Update example of str.split, bytes.split (pythonGH-121287) In `{str,bytes}.strip(chars)`, multiple characters are not treated as a prefix/suffix, but as individual characters. This may make users confuse whether `split` has similar behavior. Users may incorrectly expect that `'Good morning, John.'.split(', .') == ['Good', 'morning', 'John']` Adding a bit of clarification in the doc. (cherry picked from commit 892e3a1) Co-authored-by: Yuxin Wu <ppwwyyxxc@gmail.com> Co-authored-by: Yuxin Wu <ppwwyyxx@users.noreply.github.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 5, 2024
In `{str,bytes}.strip(chars)`, multiple characters are not treated as a
prefix/suffix, but as individual characters. This may make users confuse
whether `split` has similar behavior.
Users may incorrectly expect that
`'Good morning, John.'.split(', .') == ['Good', 'morning', 'John']`
Adding a bit of clarification in the doc.
(cherry picked from commit 892e3a1)
Co-authored-by: Yuxin Wu <ppwwyyxxc@gmail.com>
Co-authored-by: Yuxin Wu <ppwwyyxx@users.noreply.github.com>
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
In `{str,bytes}.strip(chars)`, multiple characters are not treated as a
prefix/suffix, but as individual characters. This may make users confuse
whether `split` has similar behavior.
Users may incorrectly expect that
`'Good morning, John.'.split(', .') == ['Good', 'morning', 'John']`
Adding a bit of clarification in the doc.
Co-authored-by: Yuxin Wu <ppwwyyxx@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
{str,bytes}.strip(chars), multiple characters are not treated as a prefix/suffix, but as individual characters. This may make users confuse whethersplithas similar behavior.Users may incorrectly expect that
'Good morning, John.'.split(', .') == ['Good', 'morning', 'John']Adding a bit of clarification in the doc.
📚 Documentation preview 📚: https://cpython-previews--121287.org.readthedocs.build/