Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-121201: Disable perf_trampoline on riscv64 for now #121328

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

stefanor
Copy link
Contributor

@stefanor stefanor commented Jul 3, 2024

Until support is added in perf_jit_trampoline.c

pythongh-120089 was incomplete.
@stefanor stefanor force-pushed the disable-riscv-perf-trampoline branch from c903241 to ff872eb Compare July 3, 2024 12:39
@pablogsal
Copy link
Member

The real issue is #121201

@pablogsal pablogsal changed the title gh-120400: Disable perf_trampoline on riscv64 for now gh-121201: Disable perf_trampoline on riscv64 for now Jul 3, 2024
@pablogsal pablogsal added the needs backport to 3.13 bugs and security fixes label Jul 3, 2024
@pablogsal pablogsal merged commit ca2e876 into python:main Jul 3, 2024
37 checks passed
@miss-islington-app
Copy link

Thanks @stefanor for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 3, 2024
…-121328)

Disable perf_trampoline on riscv64 for now

Until support is added in perf_jit_trampoline.c

pythongh-120089 was incomplete.
(cherry picked from commit ca2e876)

Co-authored-by: Stefano Rivera <stefano@rivera.za.net>
@bedevere-app
Copy link

bedevere-app bot commented Jul 3, 2024

GH-121336 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jul 3, 2024
@stefanor stefanor deleted the disable-riscv-perf-trampoline branch July 3, 2024 14:45
@stefanor
Copy link
Contributor Author

stefanor commented Jul 3, 2024

The real issue is #121201

Ah, thanks. I hadn't found that in my search.

pablogsal pushed a commit that referenced this pull request Jul 4, 2024
…) (#121336)

gh-121201: Disable perf_trampoline on riscv64 for now (GH-121328)

Disable perf_trampoline on riscv64 for now

Until support is added in perf_jit_trampoline.c

gh-120089 was incomplete.
(cherry picked from commit ca2e876)

Co-authored-by: Stefano Rivera <stefano@rivera.za.net>
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
…21328)

Disable perf_trampoline on riscv64 for now

Until support is added in perf_jit_trampoline.c

pythongh-120089 was incomplete.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants