Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-121359: Run test_pyrepl in isolated mode #121414

Merged
merged 1 commit into from
Jul 5, 2024
Merged

gh-121359: Run test_pyrepl in isolated mode #121414

merged 1 commit into from
Jul 5, 2024
+4 −1

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Jul 5, 2024 •
edited by bedevere-app bot
Loading

run_repl() now pass the -I option (isolated mode) to Python if the 'env' parameter is not set.

@vstinner
pythongh-121359: Run test_pyrepl in isolated mode
8f615a7 
run_repl() now pass the -I option (isolated mode) to Python if the
'env' parameter is not set.
@bedevere-app bedevere-app bot mentioned this pull request Jul 5, 2024
Open
@bedevere-app bedevere-app bot added tests Tests in the Lib/test dir awaiting core review labels Jul 5, 2024
@smontanaro
Copy link
Contributor

This solves the test_exposed_globals_in_repl failure. The test_not_wiping_history_file failure still remains (as expected, I suppose).

@smontanaro
Copy link
Contributor

I don't see a "backport" label, but note that this needs to go to 3.13 as well.

@vstinner vstinner added the needs backport to 3.13 bugs and security fixes label Jul 5, 2024
@vstinner vstinner merged commit 6239d41 into python:main Jul 5, 2024
35 checks passed
@miss-islington-app
Copy link

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@vstinner vstinner deleted the test_pyrepl_isolated branch July 5, 2024 20:30
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 5, 2024
@vstinner @miss-islington
pythongh-121359: Run test_pyrepl in isolated mode (pythonGH-121414)
e311b77 
run_repl() now pass the -I option (isolated mode) to Python if the
'env' parameter is not set.
(cherry picked from commit 6239d41)

Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-app
Copy link

bedevere-app bot commented Jul 5, 2024

GH-121417 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jul 5, 2024
@vstinner
Copy link
Member Author

vstinner commented Jul 5, 2024

This solves the test_exposed_globals_in_repl failure.

Good, thanks for testing!

The test_not_wiping_history_file failure still remains (as expected, I suppose).

As expected, it's unrelated.

I don't see a "backport" label, but note that this needs to go to 3.13 as well.

Right. I backported the change to 3.13.

vstinner added a commit that referenced this pull request Jul 5, 2024
@miss-islington @vstinner
[3.13] gh-121359: Run test_pyrepl in isolated mode (GH-121414) (#121417)
4aa0c5e 
gh-121359: Run test_pyrepl in isolated mode (GH-121414)

run_repl() now pass the -I option (isolated mode) to Python if the
'env' parameter is not set.
(cherry picked from commit 6239d41)

Co-authored-by: Victor Stinner <vstinner@python.org>
@skirpichev
Copy link
Contributor

The test_not_wiping_history_file failure still remains (as expected, I suppose).

This is fixed by #121422.

@vstinner, I think this pr address also #121271. At least, I can't reproduce that failure in the current main.

@vstinner
Copy link
Member Author

vstinner commented Jul 8, 2024

@vstinner, I think this pr address also #121271. At least, I can't reproduce that failure in the current main.

Right, I closed the issue.

noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@vstinner @noahbkim
pythongh-121359: Run test_pyrepl in isolated mode (python#121414)
c34fcad 
run_repl() now pass the -I option (isolated mode) to Python if the
'env' parameter is not set.
This was referenced Jul 13, 2024
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

@ambv ambv Awaiting requested review from ambv ambv is a code owner

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vstinner @smontanaro @skirpichev