gh-112301: -fstack-protector-strong
is also needed in LDFLAGS
on Solaris/Illumos
#121979
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linker on Solaris/Illumos is unhappy when you pass
-fstack-protector-strong
flag viaCFLAGS
but notLDFLAGS
, resulting in the following failure after #120975:I don't think that other links will mind, but I can certainly make this into a Solaris/Illumos specific
LDFLAGS
append.