Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-36157:Document PyInterpreterState_Main() #12238

Merged
merged 2 commits into from Apr 1, 2019

Conversation

@nanjekyejoannah
Copy link
Contributor

nanjekyejoannah commented Mar 8, 2019

I have added documentation for PyInterpreterState_Main().
I chose to place it under Advanced Debugger Support together with similar functions like PyInterpreterState_Head(), PyInterpreterState_Next(), and PyInterpreterState_ThreadHead() .

https://bugs.python.org/issue36157

@nanjekyejoannah

This comment has been minimized.

Copy link
Contributor Author

nanjekyejoannah commented Mar 11, 2019

@csabella csabella requested review from ericsnowcurrently and ncoghlan Mar 13, 2019
@ericsnowcurrently

This comment has been minimized.

Copy link
Member

ericsnowcurrently commented Mar 29, 2019

Thanks for working on this, @nanjekyejoannah. This PR may be a good opportunity to make sure the C-API docs are clear about what the "main" interpreter is. However, if you don't want to worry about that here it can be dealt with separately. I'll merge this the next time I take a look (giving you a few days to respond) if you go with the latter or don't respond. :)

@nanjekyejoannah

This comment has been minimized.

Copy link
Contributor Author

nanjekyejoannah commented Mar 30, 2019

@ericsnowcurrently please go on and merge this. I will work on making the C-API docs more clear in a separate PR. I opened an issue on the bug tracker to track this.

Copy link
Member

ericsnowcurrently left a comment

LGTM

@miss-islington miss-islington merged commit 8c61739 into python:master Apr 1, 2019
5 checks passed
5 checks passed
Azure Pipelines PR #20190308.25 succeeded
Details
bedevere/issue-number Issue number 36157 found
Details
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Copy link

miss-islington commented Apr 1, 2019

Thanks @nanjekyejoannah for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒🤖

@bedevere-bot

This comment has been minimized.

Copy link

bedevere-bot commented Apr 1, 2019

GH-12650 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit to miss-islington/cpython that referenced this pull request Apr 1, 2019
I have added documentation for `PyInterpreterState_Main()`.
 I chose to place it under Advanced Debugger Support together with similar functions like `PyInterpreterState_Head()`, `PyInterpreterState_Next(`), and `PyInterpreterState_ThreadHead()` .

https://bugs.python.org/issue36157
(cherry picked from commit 8c61739)

Co-authored-by: Joannah Nanjekye <33177550+nanjekyejoannah@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Apr 1, 2019
I have added documentation for `PyInterpreterState_Main()`.
 I chose to place it under Advanced Debugger Support together with similar functions like `PyInterpreterState_Head()`, `PyInterpreterState_Next(`), and `PyInterpreterState_ThreadHead()` .

https://bugs.python.org/issue36157
(cherry picked from commit 8c61739)

Co-authored-by: Joannah Nanjekye <33177550+nanjekyejoannah@users.noreply.github.com>
ma8ma added a commit to ma8ma/cpython that referenced this pull request Apr 7, 2019
I have added documentation for `PyInterpreterState_Main()`.
 I chose to place it under Advanced Debugger Support together with similar functions like `PyInterpreterState_Head()`, `PyInterpreterState_Next(`), and `PyInterpreterState_ThreadHead()` .


https://bugs.python.org/issue36157
arnolddumas added a commit to arnolddumas/cpython that referenced this pull request May 3, 2019
I have added documentation for `PyInterpreterState_Main()`.
 I chose to place it under Advanced Debugger Support together with similar functions like `PyInterpreterState_Head()`, `PyInterpreterState_Next(`), and `PyInterpreterState_ThreadHead()` .


https://bugs.python.org/issue36157
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.