bpo-36157:Document PyInterpreterState_Main() #12238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @ericsnowcurrently and @ncoghlan |
|
Thanks for working on this, @nanjekyejoannah. This PR may be a good opportunity to make sure the C-API docs are clear about what the "main" interpreter is. However, if you don't want to worry about that here it can be dealt with separately. I'll merge this the next time I take a look (giving you a few days to respond) if you go with the latter or don't respond. :) |
|
@ericsnowcurrently please go on and merge this. I will work on making the C-API docs more clear in a separate PR. I opened an issue on the bug tracker to track this. |
|
Thanks @nanjekyejoannah for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
|
GH-12650 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 1, 2019
I have added documentation for `PyInterpreterState_Main()`. I chose to place it under Advanced Debugger Support together with similar functions like `PyInterpreterState_Head()`, `PyInterpreterState_Next(`), and `PyInterpreterState_ThreadHead()` . https://bugs.python.org/issue36157 (cherry picked from commit 8c61739) Co-authored-by: Joannah Nanjekye <33177550+nanjekyejoannah@users.noreply.github.com>
miss-islington
added a commit
that referenced
this pull request
Apr 1, 2019
I have added documentation for `PyInterpreterState_Main()`. I chose to place it under Advanced Debugger Support together with similar functions like `PyInterpreterState_Head()`, `PyInterpreterState_Next(`), and `PyInterpreterState_ThreadHead()` . https://bugs.python.org/issue36157 (cherry picked from commit 8c61739) Co-authored-by: Joannah Nanjekye <33177550+nanjekyejoannah@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added documentation for
PyInterpreterState_Main().I chose to place it under Advanced Debugger Support together with similar functions like
PyInterpreterState_Head(),PyInterpreterState_Next(), andPyInterpreterState_ThreadHead().https://bugs.python.org/issue36157