[WIP] bpo-35859: Solution B #12289
Closed
[WIP] bpo-35859: Solution B #12289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
March 11, 2019 09:36
to prevent wreck the stack
MARK_PUSH() didn't protect MARK0 if it was the only available mark.
to indicate that the current operate is in a repeat.
no behavior change, just let the code uses an unified style.
added 7 commits
March 12, 2019 23:09
other JUMPs use this code: ctx->in_repeat = (state->repeat != NULL) if (ctx->in_repeat) here use: if (state->repeat) this is OK, because JUMP_ASSERT_NOT can't cross a repeat body.
reduce the size of match_context struct: On 32 bit platform, 36 bytes -> 32 bytes. On 64 bit platform, 72 bytes -> 64 bytes. adjust the order of fields, make it cache friendly.
1,073,741,823 groups should enough for most users. the size of match_context struct: On 32 bit platform: 32 bytes, no change. On 64 bit platform: 64 bytes -> 56 bytes.
* remove SRE_ERROR_RECURSION_LIMIT, this code has not been used for a long time. * return SRE_ERROR_MEMORY when allocate fail, rather than set a MemoryError and return a match failure.
could not find a test-case to prove that this is necessary.
|
See PR 12427 |
ghost
closed this
ghost
deleted the
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue35859