Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-36309: Raise a PendingDeprecationWarning when calling tempfile.mktemp() #12437

Closed
wants to merge 2 commits into from
Closed

bpo-36309: Raise a PendingDeprecationWarning when calling tempfile.mktemp() #12437

wants to merge 2 commits into from

Conversation

matrixise
Copy link
Member

@matrixise matrixise commented Mar 19, 2019 •
edited by bedevere-bot

pablogsal
pablogsal requested changes Mar 19, 2019
View reviewed changes
Copy link
Member

@pablogsal pablogsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI is failing because multiprocessing.connection is still using mktemp. Did we already settle on how we want to handle this? I don't see anything on the issue

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@matrixise
Copy link
Member Author

@pablogsal this is a WIP PR for the issue and the discussion on python-dev@python.org

@pablogsal
Copy link
Member

Ok, I will mark it as "DO-NOT-MERGE" for now, then.

@matrixise
Copy link
Member Author

I close this PR, waiting for the decision of the thread on Python-dev https://mail.python.org/pipermail/python-dev/2019-March/156721.html

@matrixise matrixise closed this Mar 24, 2019
@johnthagen johnthagen mannequin mentioned this pull request Apr 10, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal pablogsal requested changes

Assignees
No one assigned
Labels
awaiting changes DO-NOT-MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@matrixise @bedevere-bot @pablogsal @the-knights-who-say-ni