Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-24011: Use PyModule_AddIntMacro in PyInit__signal() #12765

Merged
merged 4 commits into from Apr 22, 2019
Merged

bpo-24011: Use PyModule_AddIntMacro in PyInit__signal() #12765

merged 4 commits into from Apr 22, 2019

Conversation

nanjekyejoannah
Copy link
Member

@nanjekyejoannah nanjekyejoannah commented Apr 10, 2019 •
edited by bedevere-bot

Most of the checks were added in commit : 6782b14 . I added what was left out.

https://bugs.python.org/issue24011

berkerpeksag
berkerpeksag requested changes Apr 10, 2019
View reviewed changes
Misc/NEWS.d/next/Library/2019-04-10-17-46-14.bpo-24011.tidm0a.rst Outdated Show resolved Hide resolved
Modules/signalmodule.c Outdated Show resolved Hide resolved
Modules/signalmodule.c Outdated Show resolved Hide resolved
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@berkerpeksag
Copy link
Member

Also, the title of the pull request is outdated :) We can update it with something like "Use PyModule_AddIntMacro in PyInit__signal()" since the places you've updated already have error checks in place.

@nanjekyejoannah nanjekyejoannah changed the title bpo-24011: Add error checks to PyInit_signal() bpo-24011: Use PyModule_AddIntMacro in PyInit__signal() Apr 11, 2019
@nanjekyejoannah
Copy link
Member Author

@berkerpeksag I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@berkerpeksag: please review the changes made to this pull request.

berkerpeksag
berkerpeksag requested changes Apr 11, 2019
View reviewed changes
Modules/signalmodule.c Outdated Show resolved Hide resolved
Modules/signalmodule.c Outdated Show resolved Hide resolved
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@nanjekyejoannah
Copy link
Member Author

nanjekyejoannah commented Apr 11, 2019 •
edited

@berkerpeksag Done PTAL.

@berkerpeksag berkerpeksag merged commit 9541bd3 into python:master Apr 22, 2019
@berkerpeksag
Copy link
Member

Thank you!

@nanjekyejoannah nanjekyejoannah deleted the issue24011 branch April 22, 2019 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berkerpeksag berkerpeksag berkerpeksag approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nanjekyejoannah @bedevere-bot @berkerpeksag @the-knights-who-say-ni