bpo-30202 : Update test.test_importlib.test_abc to test find_spec()

[nanjekyejoannah]

I have added a test for find_spec() in test.test_importlib.test_abc and also made some other tests use find_spec instead of find_module().

I may have not looked at all possible areas to use find_spec(), so please let me know in the reviews for this PR.

https://bugs.python.org/issue30202

[nanjekyejoannah]

ping @brettcannon for any thoughts on this PR.

[brettcannon]

@nanjekyejoannah it's in my review queue, I just need to actually start clearing my review queue. 😉 I do promise to eventually get to this, I just can't promise when (but hopefully in the next week or two).

[nanjekyejoannah]

@brettcannon got it :) , thanks!

[brettcannon]

Overall looks good, but you inadvertently removed all tests of the DeprecationWarning for find_module(). 😄 Could you add an explicit test for that?

[bedevere-bot]

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be put in the comfy chair!

[nanjekyejoannah]

I have made the requested changes; please review again.

[bedevere-bot]

Thanks for making the requested changes!

@brettcannon: please review the changes made to this pull request.

[brettcannon]

Thanks!

[nanjekyejoannah]

@brettcannon, I can close the issue now I guess?

[brettcannon]

@nanjekyejoannah I closed it. I usually do it the next time I go through my b.p.o notifications and see the commit message.