Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-36725: Refactor regrtest multiprocessing code #12961

Merged
merged 3 commits into from Apr 26, 2019
Merged

bpo-36725: Refactor regrtest multiprocessing code #12961

merged 3 commits into from Apr 26, 2019

Commits on Apr 26, 2019

  1. bpo-36725: Refactor regrtest multiprocessing code 

    Rwrite run_tests_multiprocess() function as a new MultiprocessRunner
class with multiple methods to better report errors and stop
immediately when needed.

Changes:

* Worker processes are now killed immediately if tests are
  interrupted or if a test does crash (CHILD_ERROR): child processes
  as killed.
* Rewrite how errors in a worker thread are reported to
  the main thread. No longer ignore BaseException or parsing errors
  silently.
* Remove finished variable: use worker.is_alive() instead
* Always compute omitted tests. Add Regrtest.get_executed() method.
    @vstinner
    vstinner committed Apr 26, 2019
    Configuration menu
    Copy the full SHA
    ad3d90b View commit details
    Browse the repository at this point in the history

  2. Add must_stop() helper function

    @vstinner
    vstinner committed Apr 26, 2019
    Configuration menu
    Copy the full SHA
    216c58c View commit details
    Browse the repository at this point in the history

  3. Fix KeyboardInterrupt handling

    @vstinner
    vstinner committed Apr 26, 2019
    Configuration menu
    Copy the full SHA
    a16b167 View commit details
    Browse the repository at this point in the history