Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-36722: Don't define ALT_SOABI for Py_TRACE_REFS build #12973

Merged
merged 1 commit into from Apr 26, 2019
Merged

bpo-36722: Don't define ALT_SOABI for Py_TRACE_REFS build #12973

merged 1 commit into from Apr 26, 2019

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Apr 26, 2019

Py_TRACE_REFS ABI is incompatible with release and debug (Py_DEBUG)
ABI.

https://bugs.python.org/issue36722

Py_TRACE_REFS ABI is incompatible with release and debug (Py_DEBUG)
ABI.
@vstinner
Copy link
Member Author

I checked manually pyconfig.h in these 3 configurations. It now works as expected. Moreover, pyport.h ensures that ALT_SOABI is not defined when Py_TRACE_REFS is defined, just in case.

./configure:

/* #undef ALT_SOABI */
/* #undef Py_DEBUG */
/* #undef Py_TRACE_REFS */

./configure --with-pydebug:

#define ALT_SOABI "cpython-38-x86_64-linux-gnu"
#define Py_DEBUG 1
/* #undef Py_TRACE_REFS */

./configure --with-trace-refs:

/* #undef ALT_SOABI */
/* #undef Py_DEBUG */
#define Py_TRACE_REFS 1

ALT_SOABI is only defined when Py_DEBUG is defined, but not when Py_TRACE_REFS is defined: as expected.

@vstinner vstinner merged commit 6d13e5b into python:master Apr 26, 2019
@vstinner vstinner deleted the fix_trace_refs_soabi branch April 26, 2019 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants