bpo-6584: Add a BadGzipFile exception to the gzip module #13022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Filip Gruszczyński <gruszczy@gmail.com> Co-Authored-By: Michele Orrù <maker@tumbolandia.net>
|
EOFError can be raised in some cases in the gzip module, and this was added to match with |
auvipy
approved these changes
May 2, 2019
|
It should be documented clearly that |
|
@serhiy-storchaka Thank you for your comment, Serhiy! |
serhiy-storchaka
approved these changes
May 2, 2019
|
@serhiy-storchaka, is this ready to be merged? Thanks! |
|
It was ready to merged. I just gave a chance to other core devs to make a review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-By: Filip Gruszczyński gruszczy@gmail.com
Co-Authored-By: Michele Orrù maker@tumbolandia.net
https://bugs.python.org/issue6584