Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-36166: Change to rst datamodel file. #13089

Merged
merged 1 commit into from May 4, 2019
Merged

bpo-36166: Change to rst datamodel file. #13089

merged 1 commit into from May 4, 2019

Conversation

catherinealvarado
Copy link
Contributor

@catherinealvarado catherinealvarado commented May 4, 2019 •
edited by bedevere-bot

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Our records indicate we have not received your CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels May 4, 2019
csabella
csabella approved these changes May 4, 2019
View reviewed changes
Copy link
Contributor

@csabella csabella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the PR.

@csabella csabella merged commit 5e98f05 into python:master May 4, 2019
@csabella
Copy link
Contributor

csabella commented May 4, 2019

Thanks for the PR! 🎉

@miss-islington
Copy link
Contributor

Thanks @catherinealvarado for the PR, and @csabella for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 5, 2019
@catherinealvarado @miss-islington
bpo-36166: Change to rst datamodel file. (pythonGH-13089)
ce6bf38 
(cherry picked from commit 5e98f05)

Co-authored-by: Catherine Alvarado <catherine@qventus.com>
@bedevere-bot
Copy link

GH-13094 is a backport of this pull request to the 3.7 branch.

csabella pushed a commit that referenced this pull request May 5, 2019
@miss-islington @catherinealvarado @csabella
bpo-36166: Change to rst datamodel file. (GH-13089) (#13094)
37125ff 
(cherry picked from commit 5e98f05)

Co-authored-by: Catherine Alvarado <catherine@qventus.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csabella csabella csabella approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@catherinealvarado @the-knights-who-say-ni @csabella @miss-islington @bedevere-bot