Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-36908: 'This module is always available' isn't helpful. #13297

Merged
merged 1 commit into from
May 17, 2019
Merged

bpo-36908: 'This module is always available' isn't helpful. #13297

merged 1 commit into from
May 17, 2019

Conversation

nedbat
Copy link
Member

@nedbat nedbat commented May 13, 2019 •
edited by bedevere-bot
Loading

eamanu
eamanu approved these changes May 14, 2019
View reviewed changes
Copy link
Contributor

@eamanu eamanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. :-) IMHO we need to create a section with the phrase

The next modules: math, sys ... are always available. This mean that ...

I will mention it on bpo

kushaldas
kushaldas approved these changes May 17, 2019
View reviewed changes
Copy link
Member

@kushaldas kushaldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This explanation is good. Thank you for making it easier to understand.

@kushaldas kushaldas merged commit 6faad35 into python:master May 17, 2019
@bedevere-bot
Copy link

@kushaldas: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington
Copy link
Contributor

Thanks @nedbat for the PR, and @kushaldas for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot
Copy link

GH-13394 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 17, 2019
@nedbat @miss-islington
bpo-36908: 'This module is always available' isn't helpful. (pythonGH…
94e925f 
…-13297)

Makes the documentation of math and cmath module
more helpful for the beginners.
(cherry picked from commit 6faad35)

Co-authored-by: Ned Batchelder <ned@nedbatchelder.com>
miss-islington added a commit that referenced this pull request May 17, 2019
@miss-islington @nedbat
bpo-36908: 'This module is always available' isn't helpful. (GH-13297)
740a7cd 
Makes the documentation of math and cmath module
more helpful for the beginners.
(cherry picked from commit 6faad35)

Co-authored-by: Ned Batchelder <ned@nedbatchelder.com>
@nedbat nedbat deleted the nedbat/math-is-available branch January 1, 2020 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kushaldas kushaldas kushaldas approved these changes

@eamanu eamanu eamanu approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@nedbat @bedevere-bot @miss-islington @kushaldas @eamanu @Mariatta @the-knights-who-say-ni