Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "bpo-36801: Fix waiting in StreamWriter.drain for closing SSL transport (GH-13098)" #13329

Closed
wants to merge 1 commit into from
Closed

Revert "bpo-36801: Fix waiting in StreamWriter.drain for closing SSL transport (GH-13098)" #13329

wants to merge 1 commit into from

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented May 14, 2019 •
edited by bedevere-bot
Loading

@vstinner vstinner mentioned this pull request May 14, 2019
Merged
@vstinner
Copy link
Member Author

I already reverted the change in 3.7: PR #13328.

The revert in master is motivated by https://bugs.python.org/issue36870 : test_asyncio fails randomly which causes a lot of pain in the Python CI and the Python workflow.

I don't know yet if PR #13313 fixed https://bugs.python.org/issue36870

@asvetlov
Copy link
Contributor

I don't know yet if PR #13313 fixed https://bugs.python.org/issue36870

I guess no, the PR #13313 doesn't fix your issue.
This pull request is necessary (but please don't revert #13313 and #13099)

@asvetlov
Copy link
Contributor

#13330 is a minimal change that reverts StreamWriter.drain() on the master to code that was working properly.
I suggest to use it instead, tests should pass

@vstinner
Copy link
Member Author

I suggest to use it instead, tests should pass

Honestly, I don't care: it's up to you, as soon as test_asyncio pass: as soon as https://bugs.python.org/issue36870 is fixed.

@vstinner
Copy link
Member Author

@asvetlov merged PR #13330 instead. I close this PR.

@vstinner vstinner closed this May 14, 2019
@vstinner vstinner deleted the revert_asyncio branch May 14, 2019 21:44
@asvetlov asvetlov mentioned this pull request Apr 10, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvetlov asvetlov asvetlov approved these changes

@1st1 1st1 Awaiting requested review from 1st1

@gpshead gpshead Awaiting requested review from gpshead

Assignees
No one assigned
Labels
awaiting merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vstinner @asvetlov @the-knights-who-say-ni @bedevere-bot