Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-36951: Correct some types in the type_members struct in typeobject.c #13403

Merged
merged 1 commit into from
May 20, 2019
Merged

bpo-36951: Correct some types in the type_members struct in typeobject.c #13403

merged 1 commit into from
May 20, 2019

Conversation

ZackerySpytz
Copy link
Contributor

@ZackerySpytz ZackerySpytz commented May 18, 2019 •
edited by bedevere-bot
Loading

jdemeyer
jdemeyer approved these changes May 18, 2019
View reviewed changes
Copy link
Contributor

@jdemeyer jdemeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is obviously the right thing to do.

@benjaminp benjaminp merged commit 53d378c into python:master May 20, 2019
@miss-islington
Copy link
Contributor

Thanks @ZackerySpytz for the PR, and @benjaminp for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 20, 2019
@ZackerySpytz @miss-islington
closes bpo-36951: Correct some types in the type_members struct in ty…
67bc08d 
…peobject.c. (pythonGH-13403)

(cherry picked from commit 53d378c)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@bedevere-bot
Copy link

GH-13433 is a backport of this pull request to the 3.7 branch.

@bedevere-bot
Copy link

GH-13434 is a backport of this pull request to the 2.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 20, 2019
@ZackerySpytz @miss-islington
closes bpo-36951: Correct some types in the type_members struct in ty…
d10f238 
…peobject.c. (pythonGH-13403)

(cherry picked from commit 53d378c)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
miss-islington added a commit that referenced this pull request May 20, 2019
@miss-islington @ZackerySpytz
closes bpo-36951: Correct some types in the type_members struct in ty…
eda691d 
…peobject.c. (GH-13403)

(cherry picked from commit 53d378c)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
miss-islington added a commit that referenced this pull request May 20, 2019
@miss-islington @ZackerySpytz
closes bpo-36951: Correct some types in the type_members struct in ty…
64b0bdb 
…peobject.c. (GH-13403)

(cherry picked from commit 53d378c)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdemeyer jdemeyer jdemeyer approved these changes

@benjaminp benjaminp Awaiting requested review from benjaminp

@pitrou pitrou Awaiting requested review from pitrou

@methane methane Awaiting requested review from methane

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ZackerySpytz @miss-islington @bedevere-bot @jdemeyer @benjaminp @the-knights-who-say-ni