Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-36953: Delay removal of ABCs from collections. #13409

Merged
merged 4 commits into from
May 30, 2019

Conversation

Carreau
Copy link
Contributor

@Carreau Carreau commented May 18, 2019

Bump the removal to 3.9, indicate collections.abc available since 3.3,
replace version-changed directive to deprecated-removed.

https://bugs.python.org/issue36953

@jdemeyer
Copy link
Contributor

Why do we even have to say in advance when the functionality will be removed? For this deprecation, we already said we would remove it in 3.8 but we don't. So why are we now so certain that it will be removed in 3.9?

@Carreau
Copy link
Contributor Author

Carreau commented May 19, 2019

Why do we even have to say in advance when the functionality will be removed? For this deprecation, we already said we would remove it in 3.8 but we don't. So why are we now so certain that it will be removed in 3.9?

The policy is AFAICT removal n+2 after deprecation. We do have to remove at some point no? And adding the version number for removal make it easy to search for all that was marked for removal, as well as give expectation to readers.

In any case here we are just discussing bumping the version number, which should be less controversial than discussing if their should be one.

@ilevkivskyi
Copy link
Member

I think this deserves a Misc/NEWS item.

@Carreau
Copy link
Contributor Author

Carreau commented May 20, 2019

I think this deserves a Misc/NEWS item.

Why not... done.

@Carreau Carreau changed the title bpo-25988: Delay removal of ABCs from collections. bpo-36953: Delay removal of ABCs from collections. May 20, 2019
Carreau and others added 3 commits May 20, 2019 09:33
Bump the removal to 3.9, indicate collections.abc available since 3.3,
replace version-changed directive tdeprecated-removed.
Co-Authored-By: Xtreak <tir.karthi@gmail.com>
@Carreau Carreau force-pushed the bump-collections-abcs-removal branch from 0ca83e5 to c34186d Compare May 20, 2019 16:34
@Carreau
Copy link
Contributor Author

Carreau commented May 20, 2019

Title and commits were mentioning wrong issues; rebased/edited.

Copy link
Member

@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updates, LGTM!

@miss-islington miss-islington merged commit eea47e0 into python:master May 30, 2019
rhettinger pushed a commit that referenced this pull request Aug 22, 2019
This typo was introduced in GH-13409 when changing the message text.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 22, 2019
This typo was introduced in pythonGH-13409 when changing the message text.
(cherry picked from commit c4106af)

Co-authored-by: Florian Bruhin <me@the-compiler.org>
rhettinger pushed a commit that referenced this pull request Aug 22, 2019
This typo was introduced in GH-13409 when changing the message text.
(cherry picked from commit c4106af)

Co-authored-by: Florian Bruhin <me@the-compiler.org>
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
This typo was introduced in pythonGH-13409 when changing the message text.
@miss-islington
Copy link
Contributor

Thanks @Carreau for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-16675 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 9, 2019
Bump the removal to 3.9, indicate collections.abc available since 3.3,
replace version-changed directive to deprecated-removed.

https://bugs.python.org/issue36953
(cherry picked from commit eea47e0)

Co-authored-by: Matthias Bussonnier <mbussonnier@ucmerced.edu>
miss-islington added a commit that referenced this pull request Oct 9, 2019
Bump the removal to 3.9, indicate collections.abc available since 3.3,
replace version-changed directive to deprecated-removed.

https://bugs.python.org/issue36953
(cherry picked from commit eea47e0)

Co-authored-by: Matthias Bussonnier <mbussonnier@ucmerced.edu>
ned-deily pushed a commit to ned-deily/cpython that referenced this pull request Oct 14, 2019
Bump the removal to 3.9, indicate collections.abc available since 3.3,
replace version-changed directive to deprecated-removed.

https://bugs.python.org/issue36953
(cherry picked from commit eea47e0)

Co-authored-by: Matthias Bussonnier <mbussonnier@ucmerced.edu>
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
Bump the removal to 3.9, indicate collections.abc available since 3.3,
replace version-changed directive to deprecated-removed.


https://bugs.python.org/issue36953
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
This typo was introduced in pythonGH-13409 when changing the message text.
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
This typo was introduced in pythonGH-13409 when changing the message text.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants