bpo-26185: Fix repr() on empty ZipInfo object #13441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was failing on AttributeError due to inexistant but required attributes file_size and compress_size. They are now initialized to 0 in ZipInfo.__init__().
|
This isn't up to me, but I prefer the more explicit, less magical approach you've used here than the There's a |
|
You are right, thank you :) |
Carreau
approved these changes
May 29, 2019
|
[EuroPython 2019] cc @zooba. |
DinoV
approved these changes
Sep 9, 2019
|
@DinoV: Please replace |
websurfer5
pushed a commit
to websurfer5/cpython
that referenced
this pull request
Jul 20, 2020
* bpo-26185: Fix repr() on empty ZipInfo object It was failing on AttributeError due to inexistant but required attributes file_size and compress_size. They are now initialized to 0 in ZipInfo.__init__(). * Remove useless hasattr() in ZipInfo._open_to_write() * Completely remove file_size setting in _open_to_write().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was failing on
AttributeErrordue to inexistant but required attributesfile_sizeandcompress_size.They are now initialized to
0inZipInfo.__init__().Note that this is a second patch: Matthew Zipay wrote a first one back in 2016 (see it on BPO).
I wanted propose something else less "magic". I do not mind closing this one if it is not the good patch to apply :)
https://bugs.python.org/issue26185