Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-36974: add some assertions for PEP 590 #13682

Merged
merged 1 commit into from
Jun 2, 2019
Merged

bpo-36974: add some assertions for PEP 590 #13682

merged 1 commit into from
Jun 2, 2019

Conversation

jdemeyer
Copy link
Contributor

@jdemeyer jdemeyer commented May 30, 2019 •
edited by bedevere-bot
Loading

@jdemeyer
Copy link
Contributor Author

CC @encukou

@encukou
Copy link
Member

encukou commented May 31, 2019

Is it better to have the checks here than in _PyType_CheckConsistency?

@encukou
Copy link
Member

encukou commented Jun 2, 2019

The answer is in the comment – "we require this before inheriting". I now agree that's a good thing to do.

@encukou encukou merged commit be718c3 into python:master Jun 2, 2019
@jdemeyer jdemeyer deleted the pep590_assert branch June 17, 2019 09:57
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@jdemeyer @DinoV
bpo-36974: add some assertions for PEP 590 (pythonGH-13682)
c29dc45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@auvipy auvipy auvipy approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jdemeyer @encukou @auvipy @the-knights-who-say-ni @bedevere-bot