Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-36842: Pass positional only parameters to code_new audit hook #13707

Merged
merged 1 commit into from
Jun 1, 2019
Merged

bpo-36842: Pass positional only parameters to code_new audit hook #13707

merged 1 commit into from
Jun 1, 2019

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented May 31, 2019 •
edited by bedevere-bot
Loading

@pablogsal pablogsal requested a review from zooba May 31, 2019 18:06
@pablogsal pablogsal requested a review from tiran May 31, 2019 18:06
zooba
zooba approved these changes May 31, 2019
View reviewed changes
Copy link
Member

@zooba zooba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, though only because we haven't shipped this event before. In future we'd have to create a new event name and raise both here.

@pablogsal
Copy link
Member Author

Thanks @zooba for the review!

@pablogsal pablogsal merged commit 3b57f50 into python:master Jun 1, 2019
@pablogsal pablogsal deleted the code_type_audit branch June 1, 2019 20:18
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@pablogsal @DinoV
bpo-36842: Pass positional only parameters to code_new audit hook (py…
6af815b 
…thonGH-13707)
@zooba zooba mentioned this pull request Jun 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zooba zooba zooba approved these changes

@tiran tiran Awaiting requested review from tiran

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pablogsal @zooba @the-knights-who-say-ni @bedevere-bot