Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-37134: Add PEP570 notation to the documentation #13743

Merged
merged 1 commit into from Jun 5, 2019
Merged

bpo-37134: Add PEP570 notation to the documentation #13743

merged 1 commit into from Jun 5, 2019

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Jun 2, 2019 •
edited by bedevere-bot

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting core review labels Jun 2, 2019
@pablogsal pablogsal self-assigned this Jun 2, 2019
vstinner
vstinner approved these changes Jun 5, 2019
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vstinner
Copy link
Member

vstinner commented Jun 5, 2019

Only zlib uses positional only for the first paramater? Maybe other compression libs should do the same?

willingc
willingc approved these changes Jun 5, 2019
View reviewed changes
Copy link
Contributor

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @pablogsal

@willingc willingc merged commit 54edb04 into python:master Jun 5, 2019
@alexitkes alexitkes mentioned this pull request Sep 24, 2019
Merged
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@pablogsal @DinoV
bpo-37134: Add PEP570 notation to the documentation (pythonGH-13743)
6093426
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@willingc willingc willingc approved these changes

@rhettinger rhettinger Awaiting requested review from rhettinger

@skrah skrah Awaiting requested review from skrah

@tiran tiran Awaiting requested review from tiran

@csabella csabella Awaiting requested review from csabella

@Mariatta Mariatta Awaiting requested review from Mariatta

Assignees

@pablogsal pablogsal

Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pablogsal @vstinner @willingc @the-knights-who-say-ni @bedevere-bot