Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-35431: Test math.comb() and math.perm() for OverflowError only on CPython. #14146

Merged
merged 1 commit into from Jun 17, 2019
Merged

bpo-35431: Test math.comb() and math.perm() for OverflowError only on CPython. #14146

merged 1 commit into from Jun 17, 2019

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Jun 17, 2019 •
edited by bedevere-bot

Other implementation can raise MemoryError, but it can takes hours.

https://bugs.python.org/issue35431

@serhiy-storchaka
bpo-35431: Test math.comb() and math.perm() for OverflowError only on…
b889088 
… CPython.

Other implementation can raise MemoryError, but it can takes hours.
@serhiy-storchaka serhiy-storchaka merged commit 1b8a46d into python:master Jun 17, 2019
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@serhiy-storchaka serhiy-storchaka deleted the math-comb-perm-overflow branch June 17, 2019 13:58
@miss-islington
Copy link
Contributor

Sorry @serhiy-storchaka, I had trouble checking out the 3.7 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 1b8a46d59734a77cd1f5ffcf3bdfcaafd58a87e7 3.7

@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @serhiy-storchaka, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 1b8a46d59734a77cd1f5ffcf3bdfcaafd58a87e7 3.8

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Jun 19, 2019
@serhiy-storchaka
[3.8] bpo-35431: Test math.comb() and math.perm() for OverflowError o…
ff62ab9 
…nly on CPython. (pythonGH-14146)

Other implementation can raise MemoryError, but it can takes hours.
(cherry picked from commit 1b8a46d)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.8 only security fixes label Jun 19, 2019
@bedevere-bot
Copy link

GH-14226 is a backport of this pull request to the 3.8 branch.

serhiy-storchaka added a commit that referenced this pull request Jun 23, 2019
@serhiy-storchaka
[3.8] bpo-35431: Test math.comb() and math.perm() for OverflowError o…
914d6b7 
…nly on CPython. (GH-14146) (#14226)

Other implementation can raise MemoryError, but it can takes hours.
(cherry picked from commit 1b8a46d)
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@serhiy-storchaka @lisroach
bpo-35431: Test math.comb() and math.perm() for OverflowError only on…
8b2e4f2 
… CPython. (pythonGH-14146)

Other implementation can raise MemoryError, but it can takes hours.
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@serhiy-storchaka @DinoV
bpo-35431: Test math.comb() and math.perm() for OverflowError only on…
84b1bfa 
… CPython. (pythonGH-14146)

Other implementation can raise MemoryError, but it can takes hours.
@serhiy-storchaka serhiy-storchaka removed their assignment Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@serhiy-storchaka @miss-islington @bedevere-bot @the-knights-who-say-ni