-
-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-30243: Fixed the possibility of a crash in _json. #1420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was possible to get a core dump by using uninitialized _json objects. Now __new__ methods create initialized objects. __init__ methods are removed.
serhiy-storchaka
added
type-bug
An unexpected behavior, bug, or error
needs backport to 2.7
labels
May 3, 2017
@serhiy-storchaka, thanks for your PR! By analyzing the history of the files in this pull request, we identified @tiran, @benjaminp and @loewis to be potential reviewers. |
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
May 5, 2017
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
May 5, 2017
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
May 5, 2017
serhiy-storchaka
added a commit
that referenced
this pull request
May 5, 2017
serhiy-storchaka
added a commit
that referenced
this pull request
May 5, 2017
serhiy-storchaka
added a commit
that referenced
this pull request
May 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was possible to get a core dump by using uninitialized
_json
objects. Now__new__
methods create initialized objects.__init__
methods are removed.