Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.7] bpo-28269: Replace strcasecmp with system function _stricmp. (GH-13095) #14741

Closed
wants to merge 1 commit into from
Closed

[3.7] bpo-28269: Replace strcasecmp with system function _stricmp. (GH-13095) #14741

wants to merge 1 commit into from

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jul 13, 2019 •
edited by bedevere-bot

(cherry picked from commit 05f2d84)

Co-authored-by: Minmin Gong gongminmin@msn.com

https://bugs.python.org/issue28269

@gongminmin @miss-islington
bpo-28269: Replace strcasecmp with system function _stricmp. (pythonG…
b4966d1 
…H-13095)

(cherry picked from commit 05f2d84)

Co-authored-by: Minmin Gong <gongminmin@msn.com>
@bedevere-bot bedevere-bot mentioned this pull request Jul 13, 2019
Merged
@miss-islington
Copy link
Contributor Author

@gongminmin and @serhiy-storchaka: Status check is done, and it's a success ✅ .

1 similar comment
@miss-islington
Copy link
Contributor Author

@gongminmin and @serhiy-storchaka: Status check is done, and it's a success ✅ .

@ned-deily
Copy link
Member

Given where we are in its lifecycle, I think it better to not backport this change to 3.7 now.

@ned-deily ned-deily closed this Aug 24, 2019
@miss-islington miss-islington deleted the backport-05f2d84-3.7 branch August 24, 2019 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@miss-islington @ned-deily @the-knights-who-say-ni @bedevere-bot @gongminmin