Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.5] bpo-30264: ExpatParser closes the source on error (#1451) #1475

Merged
merged 1 commit into from May 5, 2017
Merged

[3.5] bpo-30264: ExpatParser closes the source on error (#1451) #1475

merged 1 commit into from May 5, 2017

Commits on May 5, 2017

  1. bpo-30264: ExpatParser closes the source on error (#1451) 

    ExpatParser.parse() of xml.sax.xmlreader now always closes the
source: close the file object or the urllib object if source is a
string (not an open file-like object). The change fixes a
ResourceWarning on parsing error.

Add test_parse_close_source() unit test.
(cherry picked from commit ef9c0e7)
    @vstinner
    vstinner committed May 5, 2017
    Configuration menu
    Copy the full SHA
    b950de9 View commit details
    Browse the repository at this point in the history