bpo-36044: Avoid warnings in Windows PGO build and add lzma, bz2 and sqlite coverage #14985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I doubt test_bz2 and test_lzma and test_sqlite add much given the important thing is compiling the bz2 and lzma and sqlite3 libraries themselves with PGO (which isn't part of our build). but these tests in total only take ~11 seconds so it doesn't hurt. |
gpshead
approved these changes
Jul 29, 2019
|
Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 29, 2019
…sqlite coverage (pythonGH-14985) https://bugs.python.org/issue36044 Automerge-Triggered-By: @zooba (cherry picked from commit e1b9002) Co-authored-by: Steve Dower <steve.dower@python.org>
|
GH-14997 is a backport of this pull request to the 3.8 branch. |
miss-islington
added a commit
that referenced
this pull request
Jul 29, 2019
…sqlite coverage (GH-14985) https://bugs.python.org/issue36044 Automerge-Triggered-By: @zooba (cherry picked from commit e1b9002) Co-authored-by: Steve Dower <steve.dower@python.org>
lisroach
pushed a commit
to lisroach/cpython
that referenced
this pull request
Sep 10, 2019
…sqlite coverage (pythonGH-14985) https://bugs.python.org/issue36044 Automerge-Triggered-By: @zooba
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
…sqlite coverage (pythonGH-14985) https://bugs.python.org/issue36044 Automerge-Triggered-By: @zooba
websurfer5
pushed a commit
to websurfer5/cpython
that referenced
this pull request
Jul 20, 2020
…sqlite coverage (pythonGH-14985) https://bugs.python.org/issue36044 Automerge-Triggered-By: @zooba
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue36044
Automerge-Triggered-By: @zooba