Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-37730: Fix usage of NotImplemented instead of NotImplementedError in docs #15062

Merged
merged 2 commits into from Jul 31, 2019
Merged

bpo-37730: Fix usage of NotImplemented instead of NotImplementedError in docs #15062

merged 2 commits into from Jul 31, 2019

Conversation

dhdavvie
Copy link
Contributor

@dhdavvie dhdavvie commented Jul 31, 2019 •
edited by bedevere-bot

As mentioned in the BPO, there are some instances where NotImplemented is used when NotImplementedError was meant to be. This is the example I found after running rg -e NotImplemented[^E] Doc/, all other usages looked correct.

I have updated the Doc/library/winreg.rst file, and then noticed that the Clinic comments for PC/winreg.c were also incorrect. I updated these and ran python3 Tools/clinic/clinic.py PC/winreg.c to generate the new output. This is my first time fixing the docs here so if I have missed a step

https://bugs.python.org/issue37730

@dhdavvie dhdavvie requested a review from a team as a code owner July 31, 2019 22:10
@serhiy-storchaka serhiy-storchaka added skip news docs Documentation in the Doc dir needs backport to 2.7 needs backport to 3.8 only security fixes labels Jul 31, 2019
@serhiy-storchaka serhiy-storchaka merged commit ed5e8e0 into python:master Jul 31, 2019
@miss-islington
Copy link
Contributor

Thanks @dhdavvie for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.7, 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-15063 is a backport of this pull request to the 3.8 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.8 only security fixes label Jul 31, 2019
@miss-islington
Copy link
Contributor

Sorry, @dhdavvie and @serhiy-storchaka, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker ed5e8e06cbf766e89d6c58a882ee024abb5b2ed7 3.7

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 31, 2019
@miss-islington
bpo-37730: Fix usage of NotImplemented instead of NotImplementedError…
65e4ecb 
… in docs. (pythonGH-15062)

(cherry picked from commit ed5e8e0)

Co-authored-by: David H <dheiberg@mozilla.com>
@miss-islington
Copy link
Contributor

Sorry @dhdavvie and @serhiy-storchaka, I had trouble checking out the 2.7 backport branch.
Please backport using cherry_picker on command line.
cherry_picker ed5e8e06cbf766e89d6c58a882ee024abb5b2ed7 2.7

@dhdavvie dhdavvie deleted the NotImplemented_doc_fix branch July 31, 2019 22:57
@dhdavvie
Copy link
Contributor Author

Does this branch need to be open for the cherry picking?

miss-islington added a commit that referenced this pull request Aug 4, 2019
@miss-islington
bpo-37730: Fix usage of NotImplemented instead of NotImplementedError…
dd5f8ab 
… in docs. (GH-15062)

(cherry picked from commit ed5e8e0)

Co-authored-by: David H <dheiberg@mozilla.com>
@bedevere-bot
Copy link

GH-15106 is a backport of this pull request to the 3.7 branch.

serhiy-storchaka pushed a commit to serhiy-storchaka/cpython that referenced this pull request Aug 4, 2019
@serhiy-storchaka
[3.7] bpo-37730: Fix usage of NotImplemented instead of NotImplemente…
b6cd0ff 
…dError in docs. (pythonGH-15062).

(cherry picked from commit ed5e8e0)

Co-authored-by: David H <dheiberg@mozilla.com>
@serhiy-storchaka
Copy link
Member

@dhdavvie, do you mind to create a backport to 2.7?

@serhiy-storchaka serhiy-storchaka removed their assignment Aug 4, 2019
serhiy-storchaka added a commit that referenced this pull request Aug 4, 2019
@serhiy-storchaka
[3.7] bpo-37730: Fix usage of NotImplemented instead of NotImplemente…
8cd6305 
…dError in docs. (GH-15062). (GH-15106)

(cherry picked from commit ed5e8e0)

Co-authored-by: David H <dheiberg@mozilla.com>
dhdavvie pushed a commit to dhdavvie/cpython that referenced this pull request Aug 5, 2019
bpo-37730: Fix usage of NotImplemented instead of NotImplementedError…
99badf8 
… in docs. (pythonGH-15062)

(cherry picked from commit ed5e8e0)
dhdavvie pushed a commit to dhdavvie/cpython that referenced this pull request Aug 5, 2019
[2.7] bpo-37730: Fix usage of NotImplemented instead of NotImplemente…
6cb1f85 
…dError in docs. (pythonGH-15062).

(cherry picked from commit ed5e8e0)

Co-authored-by: David H <dheiberg@mozilla.com>
serhiy-storchaka pushed a commit that referenced this pull request Aug 5, 2019
@serhiy-storchaka
[2.7] bpo-37730: Fix usage of NotImplemented instead of NotImplemente…
35f9bcc 
…dError in docs. (GH-15062). (GH-15133)

(cherry picked from commit ed5e8e0)

Co-authored-by: David H <dheiberg@mozilla.com>
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@lisroach
bpo-37730: Fix usage of NotImplemented instead of NotImplementedError…
1f98b9c 
… in docs. (pythonGH-15062)
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@DinoV
bpo-37730: Fix usage of NotImplemented instead of NotImplementedError…
e6c1907 
… in docs. (pythonGH-15062)
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
@websurfer5
bpo-37730: Fix usage of NotImplemented instead of NotImplementedError…
d2496f2 
… in docs. (pythonGH-15062)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dhdavvie @miss-islington @bedevere-bot @serhiy-storchaka @the-knights-who-say-ni