Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-37775: update docs of compileall #15148

Merged
merged 3 commits into from Aug 14, 2019
Merged

bpo-37775: update docs of compileall #15148

merged 3 commits into from Aug 14, 2019

Conversation

shihai1991
Copy link
Member

@shihai1991 shihai1991 commented Aug 6, 2019 •
edited by bedevere-bot

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Aug 6, 2019
@shihai1991 shihai1991 changed the title bpo-37775: update doc of compileall bpo-37775: update docs of compileall Aug 6, 2019
@shihai1991
Copy link
Member Author

cc @vstinner @benjaminp

CuriousLearner
CuriousLearner requested changes Aug 10, 2019
View reviewed changes
Copy link
Member

@CuriousLearner CuriousLearner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a suggestion about these changes. Please find my comments inline.

Doc/library/compileall.rst Show resolved Hide resolved
@CuriousLearner
Copy link
Member

This pull request also does not require a NEWS entry and a core-developer would be able to add Skip News label that should take care of the current failing status for bedevere/news bot.

CuriousLearner
CuriousLearner approved these changes Aug 14, 2019
View reviewed changes
Copy link
Member

@CuriousLearner CuriousLearner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌮

@vstinner vstinner merged commit 68e495d into python:master Aug 14, 2019
@miss-islington
Copy link
Contributor

Thanks @shihai1991 for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 14, 2019
@shihai1991 @miss-islington
bpo-37775: Update compileall doc for invalidation_mode parameter (pyt…
a073f47 
…honGH-15148)

(cherry picked from commit 68e495d)

Co-authored-by: Hai Shi <shihai1992@gmail.com>
@bedevere-bot
Copy link

GH-15294 is a backport of this pull request to the 3.8 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.8 only security fixes label Aug 14, 2019
@miss-islington
Copy link
Contributor

Sorry, @shihai1991 and @vstinner, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 68e495df909a33e719e3f1ef5b4893ec785e10a4 3.7

@vstinner
Copy link
Member

@shihai1991: There is a conflict in the 3.7 backport. Can you please try to create a PR for Python 3.7 using "git cherry-pick -x" (and fix conflicts)?

miss-islington added a commit that referenced this pull request Aug 14, 2019
@miss-islington @shihai1991
bpo-37775: Update compileall doc for invalidation_mode parameter (GH-…
dbe4c28 
…15148)

(cherry picked from commit 68e495d)

Co-authored-by: Hai Shi <shihai1992@gmail.com>
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@shihai1991 @lisroach
bpo-37775: Update compileall doc for invalidation_mode parameter (pyt…
9bce18c 
…honGH-15148)
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@shihai1991 @DinoV
bpo-37775: Update compileall doc for invalidation_mode parameter (pyt…
9838b7c 
…honGH-15148)
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
@shihai1991 @websurfer5
bpo-37775: Update compileall doc for invalidation_mode parameter (pyt…
1b9007c 
…honGH-15148)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CuriousLearner CuriousLearner CuriousLearner approved these changes

Assignees

@vstinner vstinner

Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@shihai1991 @CuriousLearner @miss-islington @bedevere-bot @vstinner @the-knights-who-say-ni