Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-36266: Add module name in ImportError when DLL not found on Windows #15180

Merged
merged 5 commits into from Aug 17, 2019

Conversation

@shireenrao
Copy link
Contributor

commented Aug 8, 2019

@shireenrao

This comment has been minimized.

Copy link
Contributor Author

commented Aug 13, 2019

Can a reviewer having a few cycles please take a look at my PR?

Python/dynload_win.c Outdated Show resolved Hide resolved

@zooba zooba merged commit 24fe460 into python:master Aug 17, 2019

5 checks passed

Azure Pipelines PR #20190815.16 succeeded
Details
bedevere/issue-number Issue number 36266 found
Details
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Copy link

commented Aug 17, 2019

Thanks @shireenrao for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒🤖 I'm not a witch! I'm not a witch!

miss-islington added a commit to miss-islington/cpython that referenced this pull request Aug 17, 2019

bpo-36266: Add module name in ImportError when DLL not found on Windo…
…ws (pythonGH-15180)

(cherry picked from commit 24fe460)

Co-authored-by: shireenrao <shireenrao@gmail.com>
@bedevere-bot

This comment has been minimized.

Copy link

commented Aug 17, 2019

GH-15324 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Aug 17, 2019

bpo-36266: Add module name in ImportError when DLL not found on Windo…
…ws (GH-15180)

(cherry picked from commit 24fe460)

Co-authored-by: shireenrao <shireenrao@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.