Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-38110: Use fdwalk for os.closerange() when available. #15224

Merged
merged 3 commits into from
Sep 11, 2019
Merged

bpo-38110: Use fdwalk for os.closerange() when available. #15224

merged 3 commits into from
Sep 11, 2019

Conversation

kulikjak
Copy link
Contributor

@kulikjak kulikjak commented Aug 12, 2019 •
edited by gpshead
Loading

Use fdwalk() on platforms that support it to implement os.closerange().

https://bugs.python.org/issue38110

@gpshead gpshead self-requested a review September 10, 2019 15:18
@gpshead gpshead self-assigned this Sep 10, 2019
@gpshead gpshead added the needs backport to 3.8 only security fixes label Sep 10, 2019
@gpshead gpshead changed the title Use fdwalk for posix_closerange function. bpo-38110: Use fdwalk for posix_closerange function. Sep 11, 2019
@gpshead gpshead changed the title bpo-38110: Use fdwalk for posix_closerange function. bpo-38110: Use fdwalk for os.closerange() when available. Sep 11, 2019
@gpshead gpshead merged commit e20134f into python:master Sep 11, 2019
@miss-islington
Copy link
Contributor

Thanks @kulikjak for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 11, 2019
@kulikjak @miss-islington
bpo-38110: Use fdwalk for os.closerange() when available. (pythonGH-1…
318a9ae 
…5224)

Use fdwalk() on platforms that support it to implement os.closerange().
(cherry picked from commit e20134f)

Co-authored-by: Jakub Kulík <Kulikjak@gmail.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.8 only security fixes label Sep 11, 2019
@bedevere-bot
Copy link

GH-15978 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Sep 12, 2019
@miss-islington @kulikjak
bpo-38110: Use fdwalk for os.closerange() when available. (GH-15224)
84eb42e 
Use fdwalk() on platforms that support it to implement os.closerange().
(cherry picked from commit e20134f)

Co-authored-by: Jakub Kulík <Kulikjak@gmail.com>
DinoV pushed a commit to DinoV/cpython that referenced this pull request Sep 12, 2019
@kulikjak @DinoV
bpo-38110: Use fdwalk for os.closerange() when available. (pythonGH-1…
93a8380 
…5224)

Use fdwalk() on platforms that support it to implement os.closerange().
alarcher added a commit to OpenIndiana/cpython that referenced this pull request Jun 11, 2020
@alarcher
solaris-userland: 07-closerange.patch
becec9a 
Use fdwalk(3c) within os.closerange() impl to close file descriptors if available.

This patch was submitted and accepted by upstream and is part of the Python 3.8 and later.
python#15224
https://bugs.python.org/issue38110
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpshead gpshead gpshead approved these changes

Assignees

@gpshead gpshead

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kulikjak @miss-islington @bedevere-bot @gpshead @the-knights-who-say-ni