bpo-36917: Add default implementation of ast.NodeVisitor.visit_Constant(). #15490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt(). It emits a deprecation message and calls corresponding method visit_Num(), visit_Str(), etc.
serhiy-storchaka
added
type-bug
tirkarthi
reviewed
Aug 25, 2019
Co-Authored-By: Xtreak <tir.karthi@gmail.com>
asottile
approved these changes
Aug 25, 2019
|
There are no much problems with the deprecation in the same release because |
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 26, 2019
…nt(). (pythonGH-15490) It emits a deprecation warning and calls corresponding method visit_Num(), visit_Str(), etc. (cherry picked from commit c3ea41e) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
GH-15509 is a backport of this pull request to the 3.8 branch. |
serhiy-storchaka
pushed a commit
that referenced
this pull request
Aug 26, 2019
asottile
reviewed
Aug 26, 2019
| else: | ||
| import warnings | ||
| warnings.warn(f"{method} is deprecated; add visit_Constant", | ||
| DeprecationWarning, 2) |
There was a problem hiding this comment.
shouldn't this be PendingDeprecationWarning
There was a problem hiding this comment.
It is a PendingDeprecationWarning in 3.8 and a DeprecationWarning in 3.9.
There was a problem hiding this comment.
Ah right, this is to 3.9! Silly me
lisroach
pushed a commit
to lisroach/cpython
that referenced
this pull request
Sep 10, 2019
…nt(). (pythonGH-15490) It emits a deprecation warning and calls corresponding method visit_Num(), visit_Str(), etc.
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
…nt(). (pythonGH-15490) It emits a deprecation warning and calls corresponding method visit_Num(), visit_Str(), etc.
websurfer5
pushed a commit
to websurfer5/cpython
that referenced
this pull request
Jul 20, 2020
…nt(). (pythonGH-15490) It emits a deprecation warning and calls corresponding method visit_Num(), visit_Str(), etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It emits a deprecation message and calls corresponding method
visit_Num(), visit_Str(), etc.
https://bugs.python.org/issue36917