Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-38005: Fixed comparing and creating of InterpreterID and ChannelID. #15652

Merged
merged 9 commits into from Sep 13, 2019
Merged

bpo-38005: Fixed comparing and creating of InterpreterID and ChannelID. #15652

merged 9 commits into from Sep 13, 2019

Commits on Sep 2, 2019

  1. bpo-38005: Fixed comparing and creating of InterpreterID and ChannelID. 

    * They are now never equal to strings and non-integer numbers.
* Comparison with a large number no longer raises OverflowError.
* Arbitrary exceptions no longer silenced in constructors and comparisons.
* TypeError raised in the constructor contains now the name of the type.
    @serhiy-storchaka
    serhiy-storchaka committed Sep 2, 2019
    Copy the full SHA
    326bd04 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2019

  1. Fix a crash: InterpreterID and ChannelID are not proper int subclasses.

    @serhiy-storchaka
    serhiy-storchaka committed Sep 8, 2019
    Copy the full SHA
    6c28b76 View commit details
    Browse the repository at this point in the history

  2. Use a converter function and O&.

    @serhiy-storchaka
    serhiy-storchaka committed Sep 8, 2019
    Copy the full SHA
    5524e62 View commit details
    Browse the repository at this point in the history

  3. Accept only ChannelID and int-like objects in channel functions.

    @serhiy-storchaka
    serhiy-storchaka committed Sep 8, 2019
    Copy the full SHA
    b6bf9c3 View commit details
    Browse the repository at this point in the history

  4. Accept only InterpreterId, int-like objects and str in the Interprete… 

    …rId constructor.
    @serhiy-storchaka
    serhiy-storchaka committed Sep 8, 2019
    Copy the full SHA
    f3603dd View commit details
    Browse the repository at this point in the history

  5. Accept int-like objects, not just int in interpreter related functions.

    @serhiy-storchaka
    serhiy-storchaka committed Sep 8, 2019
    Copy the full SHA
    b768077 View commit details
    Browse the repository at this point in the history

  6. Unify error messages.

    @serhiy-storchaka
    serhiy-storchaka committed Sep 8, 2019
    Copy the full SHA
    052fc77 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2019

  1. Merge branch 'master' into interpreter-id

    @serhiy-storchaka
    serhiy-storchaka committed Sep 13, 2019
    Copy the full SHA
    c8219f9 View commit details
    Browse the repository at this point in the history

  2. Rewrite some tests in simpler form.

    @serhiy-storchaka
    serhiy-storchaka committed Sep 13, 2019
    Copy the full SHA
    6d56a37 View commit details
    Browse the repository at this point in the history