Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-36324: Apply review comment from Jake Vanderplas #15695

Merged
merged 1 commit into from
Sep 5, 2019
Merged

bpo-36324: Apply review comment from Jake Vanderplas #15695

merged 1 commit into from
Sep 5, 2019

Conversation

rhettinger
Copy link
Contributor

@rhettinger rhettinger commented Sep 5, 2019 •
edited by bedevere-bot
Loading

@rhettinger rhettinger added docs Documentation in the Doc dir skip news needs backport to 3.8 only security fixes labels Sep 5, 2019
@rhettinger rhettinger merged commit 9b51570 into python:master Sep 5, 2019
@rhettinger rhettinger deleted the stats_vanderplas branch September 5, 2019 08:03
@miss-islington
Copy link
Contributor

Thanks @rhettinger for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-15696 is a backport of this pull request to the 3.8 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.8 only security fixes label Sep 5, 2019
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 5, 2019
@rhettinger @miss-islington
bpo-36324: Apply review comment from Jake Vanderplas (pythonGH-15695)
1962942 
(cherry picked from commit 9b51570)

Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>
rhettinger added a commit that referenced this pull request Sep 5, 2019
@miss-islington @rhettinger
bpo-36324: Apply review comment from Jake Vanderplas (GH-15695) (GH-1…
f5649bf 
…5696)

(cherry picked from commit 9b51570)

Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@rhettinger @lisroach
bpo-36324: Apply review comment from Jake Vanderplas (pythonGH-15695)
a506220
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@rhettinger @DinoV
bpo-36324: Apply review comment from Jake Vanderplas (pythonGH-15695)
e0e21be
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
@rhettinger @websurfer5
bpo-36324: Apply review comment from Jake Vanderplas (pythonGH-15695)
c2e3024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rhettinger @miss-islington @bedevere-bot @the-knights-who-say-ni